Problem/Motivation

Please create a version that also supports Drupal 10 as Drupal 9 reaches its end of life.
It would be great if you could create a regular release to avoid dependencies on test versions.

Steps to reproduce

Try to install the module on a Drupal 10.1 site.

Proposed resolution

Update dependencies and create a new version.

Thanks a lot for your work!

Issue fork commerce_unzer-3394485

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gruberroland created an issue. See original summary.

sarwan_verma made their first commit to this issue’s fork.

sarwan_verma opened merge request !2

cspitzlay’s picture

cspitzlay
Primary language German
Location 🇩🇪🇪🇺
commented
Status: Active » Needs work

The changes to line 57 of js/commerce_unzer.form.js seem wrong. Do they work for you?

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Priority: Major » Normal
sarwan_verma’s picture

sarwan_verma commented

Hi, sorry for my mistake. I raised the PR without checking. But now I have fixed this mistake.

Please review this new MR.

cspitzlay’s picture

cspitzlay
Primary language German
Location 🇩🇪🇪🇺
commented

The patch updates the PHP version requirement to >= 8.1 although the Unzerdev SDK still supports 7.4.

Since Drupal 9 is no longer supported now (https://www.drupal.org/docs/understanding-drupal/drupal-9-release-date-a...) and Drupal 10 requires at least PHP 8.1 (https://www.drupal.org/docs/getting-started/system-requirements/php-requ...) I think we can accept that.

cspitzlay’s picture

cspitzlay
Primary language German
Location 🇩🇪🇪🇺
commented

Here's the change record for the JavaScript change: https://www.drupal.org/node/3158256

  • cspitzlay committed 7255f762 on 1.0.x 
    Issue #3394485 by sarwan_verma: Remove dependency on jQuery once (D10...
cspitzlay’s picture

cspitzlay
Primary language German
Location 🇩🇪🇪🇺
commented

@gruberroland : I committed the patch that removes the dependency on jQuery once.

  • Are you aware of any remaining issues with respect to D10 compatibility?
    Other than packaging a release, I mean.
  • Are you using the onsite payment gateway? That part is known to have worked at least at some point but we do not use it in our project so it sees little testing.
cspitzlay’s picture

cspitzlay
Primary language German
Location 🇩🇪🇪🇺
commented
Status: Needs work » Postponed (maintainer needs more info)
gruberroland’s picture

gruberroland commented

I can confirm that the current DEV version works with Drupal 10.1.6 with offsite payment gateway.
The onsite gateway seems to work, too. My test order was successful. But I do not use this in production as it does not support e.g. SEPA direct debit.

cspitzlay’s picture

cspitzlay
Primary language German
Location 🇩🇪🇪🇺
commented
Status: Postponed (maintainer needs more info) » Active

I created an issue some days ago about code quality improvements and modernization:
https://www.drupal.org/project/commerce_unzer/issues/3403407

I made the changes I had in mind and will soon create a new alpha release.

cspitzlay closed merge request !2

dimaro’s picture

dimaro commented
Status: Active » Needs review

Hello @cspitzlay, taking into account that the Merge request was closed 3 months ago, it could be said that this issue is already solved and therefore this should be marked as "Fixed", right? os is there something else undone? Thanks!

cspitzlay’s picture

cspitzlay
Primary language German
Location 🇩🇪🇪🇺
commented
Status: Needs review » Fixed

Well, we are still at an alpha version and not a stable release.
But then again: D11 is near so keeping this open may not make much sense.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.