Since #956186: Allow AJAX to use GET requests and #3352984: Use httpMethod instead of type for AJAX get/post request property it is possible to open a dialog with Ajax via a GET request. However, with this link:
<a href="/some/path"
class="use-ajax"
data-dialog-type="modal"
data-dialog-options="{"width":800}"
data-ajax-http-method="GET"
>Open dialog</a>
... the dialog options (data-dialog-options) are not followed. With POST everything works.
The MR contains a test proving the bug
See the test.
Fix it.
None.
None.
None.
None.
N/A
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !5016
Comments
Comment #3
claudiu.cristeaComment #4
claudiu.cristeaOK, we have green. Ready for review.
Comment #5
catchLeft a comment on the MR but then looked a bit more - Symfony marked Request::get() internal in Symfony 5.4, so we probably shouldn't go out of our way to use it (although I personally think the 'get this from GET or POST' is useful). Given that was my only question here, moving to RTBC. We probably don't need to worry about existing usages of Request::get() until and if Symfony actually deprecates it though.
Comment #6
claudiu.cristeaThe
data-ajax-http-methodattribute hasn't been documented anywhere. Added few words here https://www.drupal.org/node/3089078/revisions/view/13205552/13270791Comment #11
lauriiiCommitted 291d8a2 and pushed to 11.x. Cherry-picked all the way to 10.1.x. Thanks!
Comment #13
claudiu.cristeaCrediting @huzooka as he has discovered the bug