Problem/Motivation

Some users have working code that is compatible with OpenID Connect / OAuth client 8.x-1.2, and have a November 1, 2023 deadline for upgrading their systems to Drupal 10.

Steps to reproduce

Proposed resolution

Provide a Drupal-10 compatible version of OpenID Connect / OAuth client 8.1-1.x.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork openid_connect-3393666

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mikegodin created an issue. See original summary.

mikegodin opened merge request !91

mikegodin’s picture

mikegodin commented

The MR 191, when tested locally, passed all PHP Unit tests and all Upgrade Status tests with no deprecation warnings.

mikegodin’s picture

mikegodin commented

Noting that the "PHP 7.4 & MySQL 5.7, D10.1.4 Composer require failure" is expected since Drupal 10 requires PHP 8.1.

mikegodin’s picture

mikegodin commented
Status: Active » Needs review
mikegodin’s picture

mikegodin commented

If it is necessary to install this fork via composer before it gets merged, edit composer.json, replacing:

    "repositories": [
        {
            "type": "composer",
            "url": "https://packages.drupal.org/8"
        }

with 

    "repositories": [
        {
            "type": "composer",
            "url": "https://packages.drupal.org/8",
            "exclude": [
                "drupal/openid_connect"
            ]
        },
        {
            "type": "git",
            "url": "https://git.drupalcode.org/issue/openid_connect-3393666.git"
        }

Then require via composer:

composer require 'drupal/openid_connect:dev-3393666-drupal-10-compatibility' --with-all-dependencies

Harlor made their first commit to this issue’s fork.

harlor’s picture

harlor commented

@mikegodin, THX for your help!

I asked one of the maintainers (sanduhrs) about this issue and we decided to bring back the deprecation annotations because these functions are not static in 2.x and 3.x.

I also moved the helper method from the tests to a trait so we don't need to duplicate it.

harlor’s picture

harlor commented
Status: Needs review » Reviewed & tested by the community
Related issues: +#3391127: New release for 3.x

I manually tested these changes with a Drupal 10. And it seemed to work just fine!

Even though I made the last changes to the MR I set this to RTBC - my changes where purely cosmetic and coordinated with sanduhrs.

harlor’s picture

harlor commented
Related issues: +#3288878: Automated Drupal 10 compatibility fixes

sanduhrs’s picture

sanduhrs
he/him
Primary language German
Location 🇪🇺 Heidelberg, Germany, Europe
commented
Status: Reviewed & tested by the community » Fixed

Merged, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.