Problem/Motivation

We have been using a custom version of this module on one of our projects. The processing has been expanded to include todo items and to ensure that payment details are updated on time for submission. Error handling has also been improved

Proposed resolution

The proposed solution described above will be added as a patch here open for review by the community.

Remaining tasks

Review of the solution by the community.

CommentFileSizeAuthor
#9 updated_processing_and_error_handling-3393194-9.patch16.17 KBroaldnel
#8 updated_processing_and_error_handling-3393194-8.patch16.17 KBroaldnel
#4 updated_processing_and_error_handling-3393194-4.patch16.69 KBroaldnel
#2 updated_processing_and_error_handling-3393194-2.patch16.72 KBroaldnel

Comments

roaldnel created an issue. See original summary.

roaldnel’s picture

roaldnel commented
StatusFileSize
new updated_processing_and_error_handling-3393194-2.patch16.72 KB

The patch containing the updated code is attached.

roaldnel’s picture

roaldnel commented
Status: Active » Needs review

Updated the status to needs review.

roaldnel’s picture

roaldnel commented
StatusFileSize
new updated_processing_and_error_handling-3393194-4.patch16.69 KB

The patch was updated with codesniffer improvements applied.

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Issue tags: +finalist-sprint
arantxio’s picture

arantxio
Primary language Dutch
Location Dordrecht
commented
Status: Needs review » Needs work 
+++ b/cm_commerce.info.yml
@@ -3,6 +3,6 @@ type: module
+core_version_requirement: ^8 || ^9 || ^10

We add D10 support here, but that is handled in another issue so it doesn't fit in here. #3386410: Drupal 10 update

Otherwise I do not see any problems here.

roaldnel’s picture

roaldnel commented
Status: Needs work » Needs review

Thanks Arantxio, I have removed the D10 support change and I also removed support for Drupal 8 as you suggested in this issue: https://www.drupal.org/project/cm_commerce/issues/3386410#comment-15332689.

roaldnel’s picture

roaldnel commented
StatusFileSize
new updated_processing_and_error_handling-3393194-8.patch16.17 KB

And here is the updated patch

roaldnel’s picture

roaldnel commented
Version: 1.0.2 » 1.0.4
StatusFileSize
new updated_processing_and_error_handling-3393194-9.patch16.17 KB

Added D10 support back in since it has been released already, the updated patch is attached.

arantxio’s picture

arantxio
Primary language Dutch
Location Dordrecht
commented
Status: Needs review » Reviewed & tested by the community

Thanks for the updated code @roaldnel, looks fine to be released.

  • roaldnel committed 729ba220 on main 
    Issue #3393194 by roaldnel: Updated processing and error handling
roaldnel’s picture

roaldnel commented
Version: 1.0.4 » 1.0.5
Status: Reviewed & tested by the community » Fixed

The code has been merged and Drupal 8 support was dropped.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.