Problem/Motivation

\Drupal\rabbitmq\Queue\Queue::createItem($data): bool expects bool, but string|false is actually returned. It doesn't seem to fail because the file doesn't have a strict_types declaration (declare(strict_types=1)).

API changes

\Drupal\rabbitmq\Queue\Queue::createItem($data) return type changed to bool|string

Issue fork rabbitmq-3392889

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tuutti created an issue. See original summary.

tuutti opened merge request !38

cmlara’s picture

cmlara
he/him
commented

Interesting, I had thought return types were strict always apparently they are coerced as well.

I've added an additional commit with a test change as well to prevent regression as this was a tested portion of code.

cmlara’s picture

cmlara
he/him
commented
Status: Active » Needs review

  • cmlara committed ad0fcd89 on 4.x authored by tuutti 
    Issue #3392889 by tuutti, cmlara: Queue::createItem() has an invalid...
cmlara’s picture

cmlara
he/him
commented
Status: Needs review » Fixed

Merged to Dev.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.