Problem/Motivation

In contact form, the preview message has some styling issues.

  1. Padding issue
  2. Visibility issue

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#14 contact_preview_design.png141.15 KBesha_kundu
#14 after_comment_preview.png1.15 MBesha_kundu
#13 Screenshot from 2024-09-09 12-57-19.png74.34 KBtanushree gupta
#13 Screenshot from 2024-09-09 12-56-34.png65.21 KBtanushree gupta
#12 comment_preview.png1.28 MBesha_kundu
#12 preview_msg_after_MR9.png75.84 KBesha_kundu
#12 preview_msg_after_MR1.png374.04 KBesha_kundu
#12 preview_msg_before.png293.29 KBesha_kundu
#11 Screenshot from 2024-08-01 10-36-06.png89.61 KBtanushree gupta
#11 Screenshot from 2024-08-01 10-37-28.png63.47 KBtanushree gupta
#9 Screenshot from 2024-07-22 13-06-39.png33.48 KBriddhi.addweb
#9 Screenshot from 2024-07-22 12-59-15.png34.11 KBriddhi.addweb
#4 In contact form, preview message has some styling issues..PNG26.55 KBshiv_yadav
Screenshot at Oct 10 00-10-55.png216.42 KBshweta__sharma

Issue fork classic_corporate_theme-3392746

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

shweta__sharma created an issue. See original summary.

shiv_yadav made their first commit to this issue’s fork.

shiv_yadav opened merge request !1

shiv_yadav’s picture

shiv_yadav
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new In contact form, preview message has some styling issues..PNG26.55 KB

Hello Shewta, I have fixed this issue. Created MR & attached screenshot.
Please review & retested it.

kanchan bhogade’s picture

kanchan bhogade commented
Status: Needs review » Needs work

Hi @shiv_yadav
checked on Drupal 10.2, the issue is reproduced
Applied MR !1 successfully but no visual changes after the patch.

moving to "needs work"

tanushree gupta’s picture

tanushree gupta commented
Assigned: Unassigned » tanushree gupta

Tanushree Gupta opened merge request !9

tanushree gupta’s picture

tanushree gupta commented
Assigned: tanushree gupta » Unassigned
Status: Needs work » Needs review

Updated the design of preview message and form.
Here is the MR: https://git.drupalcode.org/project/classic_corporate_theme/-/merge_reque...

riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Needs work
StatusFileSize
new Screenshot from 2024-07-22 12-59-15.png34.11 KB
new Screenshot from 2024-07-22 13-06-39.png33.48 KB

I have applied the MR9 patch [It applied cleanly], but with and without the patch the issue looks the same, no visual changes are displayed. Attaching SS for the same and moving to Needs to Work.

tanushree gupta’s picture

tanushree gupta commented
Assigned: Unassigned » tanushree gupta
tanushree gupta’s picture

tanushree gupta commented
Assigned: tanushree gupta » Unassigned
Status: Needs work » Needs review
StatusFileSize
new Screenshot from 2024-08-01 10-37-28.png63.47 KB
new Screenshot from 2024-08-01 10-36-06.png89.61 KB

The merge request work perfectly fine, as I have checked.
Here is a screenshot I am attaching for reference, showing the before and after images.

esha_kundu’s picture

esha_kundu commented
Status: Needs review » Needs work
StatusFileSize
new preview_msg_before.png293.29 KB
new preview_msg_after_MR1.png374.04 KB
new preview_msg_after_MR9.png75.84 KB
new comment_preview.png1.28 MB

Hello @Tanushree Gupta,
I've installed 2.0.1 version of Simple Classic Corporate Theme on Drupal version 10.3.2, the visibility and padding issue while previewing the contact form still persist. Initially I applied the MR!1 provided in #4 and the patch applied cleaning resolving just the padding issue while the visibility issue still persist. I removed the changes applied in MR!1 followed by the application of MR!9, that applied cleanly. The design of the form was improved and the stated issue of visibility, padding was also resolved. I've reviewed the MR!9, changes are made targeting the form element due to which the comment form design is also altered and as per the issue we don't need to change the design of all forms. In case, we need to improve the contact form design we can just include css for that only without affecting other forms. Have attach ss regarding the changes in comment form in node page while previewing, before and after of the contact preview message.
Thanks

tanushree gupta’s picture

tanushree gupta commented
Status: Needs work » Needs review
StatusFileSize
new Screenshot from 2024-09-09 12-56-34.png65.21 KB
new Screenshot from 2024-09-09 12-57-19.png74.34 KB

@esha_kundu Thank you for your feedback.
I have update the code according to your suggestion.
Here are the screenshots I am attaching for the reference.
Indicating that the style will only apply to contact form not every form in the site.
Commit id: https://git.drupalcode.org/project/classic_corporate_theme/-/merge_reque...

esha_kundu’s picture

esha_kundu commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new after_comment_preview.png1.15 MB
new contact_preview_design.png141.15 KB

Hello,
I've reviewed the changes in MR!9, the code looks good. I've applied the new changes and the MR applied cleanly. Checked the contact form preview visibility and spacing, which was resolved. Checked the issue while previewing comments in nodes that I had mentioned previously in #12, the style that was being applied previously due to targeting the form element has been resolved.
Attaching the ss for reference. Moving to RTBC.
Thanks

jaykandari’s picture

jaykandari
Primary language Hindi
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.