The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Problem/Motivation
In contact form, the preview message has some styling issues.
- Padding issue
- Visibility issue
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | contact_preview_design.png | 141.15 KB | esha_kundu |
| #14 | after_comment_preview.png | 1.15 MB | esha_kundu |
| #13 | Screenshot from 2024-09-09 12-57-19.png | 74.34 KB | tanushree gupta |
| #13 | Screenshot from 2024-09-09 12-56-34.png | 65.21 KB | tanushree gupta |
| #12 | comment_preview.png | 1.28 MB | esha_kundu |
Issue fork classic_corporate_theme-3392746
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #4
shiv_yadavHello Shewta, I have fixed this issue. Created MR & attached screenshot.
Please review & retested it.
Comment #5
kanchan bhogade commentedHi @shiv_yadav
checked on Drupal 10.2, the issue is reproduced
Applied MR !1 successfully but no visual changes after the patch.
moving to "needs work"
Comment #6
tanushree gupta commentedComment #8
tanushree gupta commentedUpdated the design of preview message and form.
Here is the MR: https://git.drupalcode.org/project/classic_corporate_theme/-/merge_reque...
Comment #9
riddhi.addweb commentedI have applied the MR9 patch [It applied cleanly], but with and without the patch the issue looks the same, no visual changes are displayed. Attaching SS for the same and moving to Needs to Work.
Comment #10
tanushree gupta commentedComment #11
tanushree gupta commentedThe merge request work perfectly fine, as I have checked.
Here is a screenshot I am attaching for reference, showing the before and after images.
Comment #12
esha_kundu commentedHello @Tanushree Gupta,
I've installed 2.0.1 version of Simple Classic Corporate Theme on Drupal version 10.3.2, the visibility and padding issue while previewing the contact form still persist. Initially I applied the MR!1 provided in #4 and the patch applied cleaning resolving just the padding issue while the visibility issue still persist. I removed the changes applied in MR!1 followed by the application of MR!9, that applied cleanly. The design of the form was improved and the stated issue of visibility, padding was also resolved. I've reviewed the MR!9, changes are made targeting the form element due to which the comment form design is also altered and as per the issue we don't need to change the design of all forms. In case, we need to improve the contact form design we can just include css for that only without affecting other forms. Have attach ss regarding the changes in comment form in node page while previewing, before and after of the contact preview message.
Thanks
Comment #13
tanushree gupta commented@esha_kundu Thank you for your feedback.
I have update the code according to your suggestion.
Here are the screenshots I am attaching for the reference.
Indicating that the style will only apply to contact form not every form in the site.
Commit id: https://git.drupalcode.org/project/classic_corporate_theme/-/merge_reque...
Comment #14
esha_kundu commentedHello,
I've reviewed the changes in MR!9, the code looks good. I've applied the new changes and the MR applied cleanly. Checked the contact form preview visibility and spacing, which was resolved. Checked the issue while previewing comments in nodes that I had mentioned previously in #12, the style that was being applied previously due to targeting the form element has been resolved.
Attaching the ss for reference. Moving to RTBC.
Thanks
Comment #15
jaykandari