Problem/Motivation

_TARGET_DB_TYPE is used in the GitLab CI files and it does not exist. It's from a previous iteration.

Steps to reproduce

It's used in the test-only job and it will fail silently and fall back to whatever was set previously.

Proposed resolution

Fix from _TARGET_DB_TYPE to _TARGET_DB

Remaining tasks

MR

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3392739

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fjgarlin created an issue. See original summary.

fjgarlin opened merge request !4969

fjgarlin’s picture

fjgarlin commented
Status: Active » Needs review

MR is ready for review.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Looks good, will commit in the morning if nothing comes up.

bbrala’s picture

bbrala
Location Netherlands
commented

Yeah, this is good. Silly that slipped through.

catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 10.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 10.1.x, thanks!

  • catch committed cded23dd on 10.1.x 
    Issue #3392739 by fjgarlin: _TARGET_DB_TYPE does not exist

(cherry...

  • catch committed 33868698 on 11.x 
    Issue #3392739 by fjgarlin: _TARGET_DB_TYPE does not exist
catch’s picture

catch
he/him
Primary language English
commented

I think there's something still wrong here:

declare -x _TARGET_DB="mysql-8"
declare -x _TARGET_DB_TYPE="mysql"
declare -x _TARGET_DB_VERSION="5.7"

From https://git.drupalcode.org/project/drupal/-/jobs/165210

Note TARGET_DB there is mysql-8 so it doesn't match the test against _TARGET_DB when determining SIMPLETEST_DB

catch’s picture

catch
he/him
Primary language English
commented
Status: Fixed » Active

Re-opening, I think the database type checks are wrong now, or I'm missing something.

catch’s picture

catch
he/him
Primary language English
commented

Also the branch tests look wrong to me, only running on one environment.

https://git.drupalcode.org/project/drupal/-/pipelines?scope=branches&page=1

longwave made their first commit to this issue’s fork.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

The above commit fixes the test-only runs; we need a wildcard check on TARGET_DB.

Branch tests look OK to me: https://git.drupalcode.org/project/drupal/-/pipelines/29420 ran on four environments, failed on one.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Ahhhh! That looks right.

fjgarlin’s picture

fjgarlin commented

Doh! I should have remembered that change too! Thanks for fixing that. Looks good.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 8e33624c95 to 11.x and 64113ded7b to 10.2.x and 9538b30d4d to 10.1.x. Thanks!

  • longwave committed 9538b30d on 10.1.x 
    Issue #3392739 followup by fjgarlin, longwave, catch: _TARGET_DB_TYPE...

  • longwave committed 64113ded on 10.2.x 
    Issue #3392739 followup by fjgarlin, longwave, catch: _TARGET_DB_TYPE...

  • longwave committed 8e33624c on 11.x 
    Issue #3392739 followup by fjgarlin, longwave, catch: _TARGET_DB_TYPE...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.