Problem/Motivation
I'd like to expose an org (single entity, but not a person) vCard with this module, but am currently prevented from doing so due to the module requiring first and last name. The organization does not have a first and last name.
It appears the module is exposing a v4 card, and from what I can tell, looking at the Wikipedia entry and the RFC 6350 spec doc, the only required properties in a v4 vCard are:
- BEGIN
- END
- FN
- VERSION
The module seems to be requiring properties that are not actually required by the vCard 4.0 spec, which currently blocks my use case (and others).
Steps to reproduce
1. Create a vCard view.
2. Under Format -> Show, click "Settings" and see that First name, Last name, Full name, and Primary E-Mail are required fields.
Proposed resolution
Require only the properties that are actually required by the vCard 4.0 spec. Given that the module automatically includes the BEGIN, END, and VERSION properties, I think that leaves us with requiring only FN (full name).
Remaining tasks
Patch, review.
User interface changes
Fewer required fields.
API changes
None.
Data model changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | views_vcards-required-properties-bug-3392234-2.patch | 3.07 KB | chrisolof |
Comments
Comment #2
chrisolofThe attached patch reduces the required properties to just full name (FN), leaving everything else optional.
Comment #3
neograph734Thanks for making me aware of this and taking a first stab at the patch. I believe it requires a
{{ "\n" }}to have a proper line break and then it will pass.I'll gladly merge the patch then.
Comment #5
neograph734Committed to -dev. Please let me know if it works and then I will tag a new release.
Comment #6
chrisolofJust pulled in the latest 3.x and tested. It does appear to be working - thank you!