Problem/Motivation

  • Fix status messages when to attach and detach an OpenStack Volume in SPA (drupal/cloud_dashboard).

Issue fork cloud-3392137

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !2059

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

Please review it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Needs work

@ryo-yamashita

Can you please check the coding standard error? Thanks!

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I fixed the code for the coding standard. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the patch. I posted my comment.

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

In each class, it has been modified to use Messenger derived from Trait. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the update. It looks more simpler and good to me now. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed 8528e8bb on 6.x authored by Ryo Yamashita 
    Issue #3392137 by Ryo Yamashita, yas: Fix status messages when to attach...

  • yas committed 71e7bacc on 5.x authored by Ryo Yamashita 
    Issue #3392137 by Ryo Yamashita, yas: Fix status messages when to attach...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.