This module uses a mix of "JS Injector" 3x and "Js Injector" 9x. I think "JS" (all upper case) is more common, matches "CSS" and also aligns better with https://www.drupal.org/node/604342#interface-text-acronym.

CommentFileSizeAuthor
#2 asset_injector-3391453-2.patch3.1 KBbwaindwain

Issue fork asset_injector-3391453

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bwaindwain created an issue. See original summary.

bwaindwain’s picture

bwaindwain commented
Status: Active » Needs review
StatusFileSize
new asset_injector-3391453-2.patch3.1 KB
trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

LGTM RTBC

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Could you please provide this as MR? I'd agree that JS is more common, but maintainers have to make the final decision. +1 on that from my side.

bwaindwain opened merge request !19

bwaindwain’s picture

bwaindwain commented

MR has been created

lrwebks’s picture

lrwebks commented
Title: Upper case "JS" » Upper case "JS" and "CSS"
Status: Reviewed & tested by the community » Needs work

Found some things left over/new:

  • A few missed js or Js spellings
  • I found out that CSS is also inconsistently spelled sometimes
  • A few comments where apparently JS is confused with CSS

I'll be fixing that quickly! Good find with the inconsistent spellings in the first place, definitely hate it to see such things in the UI! :)

lrwebks’s picture

lrwebks commented
Status: Needs work » Needs review

Done with that!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Wonderful work and additions @LRWebks! RTBC! :)

pookmish’s picture

pookmish commented
Status: Reviewed & tested by the community » Needs work

Merge conflicts exist in the MR due to another issue getting merged. Please update the MR.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs work » Needs review

@pookmish resolved!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Setting this back to RTBC then.

pookmish’s picture

pookmish commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.