Problem/Motivation

From #3358566: Plan to 8.x-1.5 release

Before we tag the release, we need someone to actually test the dev branch, try at least most of the pages that might be funky (/user, a page view, home, a taxonomy term, an edit form), and report back. It's quite common for base features to get broken in dev branch because each patch gets tested individually, but no one tests the entire module set once it's been merged in a complete release.

Proposed resolution

- Identify base features that should be covered by tests
- Add tests covering their functionality
- Review
- Commit

CommentFileSizeAuthor
#2 current_page_crumb-basic-load-test-3391221-2.patch1.22 KBericgsmith

Issue fork current_page_crumb-3391221

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ericgsmith created an issue. See original summary.

ericgsmith’s picture

ericgsmith commented
StatusFileSize
new current_page_crumb-basic-load-test-3391221-2.patch1.22 KB

Adding a basic test - looks like automated testing isn't setup, would make sense to expand this to cover setting up gitlab ci

ericgsmith’s picture

ericgsmith commented
Status: Active » Needs work
greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented

Looks good. I'd say, we want a test that a crumb exists on a content page and that the text of the crumb equals the page title.

Ideally we probably want a test for:

1. A node page
2. A view page /node maybe?
3. A user profile page
4. A taxonomy term page
5. A translated node

prudloff made their first commit to this issue’s fork.

prudloff opened merge request !9

prudloff’s picture

prudloff commented

We now have a working CI. I created a MR so that we can run the tests.

@ericgsmith would you still be interested in writing more tests?

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Category: Feature request » Task
Status: Needs work » Needs review

I suggest this be merged so that there is something. More tests can be added later.

prudloff’s picture

prudloff commented
Status: Needs review » Fixed

I'm not a huge fan of having a test that checks basically nothing.
I added a unit test based on PathBasedBreadcrumbBuilderTest and a functional test based on BreadcrumbTest from core.

Right now they mostly test that the module does not break the breadcrumbs. They should probably be extended to test that the module does its job correctly (adding the node title at the end) but this could be done in a followup.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • prudloff committed 81ae538b on 8.x-1.x 
    feat: #3391221 Add automated testing

By: ericgsmith
By: prudloff
By:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.