Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork orange_dam-3390295

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

adamzimmermann created an issue. See original summary.

adamzimmermann opened merge request !36

apotek’s picture

apotek commented

Here are usages of getContentItem() in the module:

grep -Rn getContentItem orange_dam 
orange_dam/src/OrangeDamApi.php:235:  public function getContentItem(string $system_identifier) {
orange_dam/src/OrangeDamQueueDataManager.php:195:    if ($item = $this->orangeDamApi->getContentItem($system_identifier)) {
orange_dam/src/OrangeDamQueueDataManager.php:406:      $item = $this->orangeDamApi->getContentItem($system_id);
orange_dam/src/Commands/OrangeDamCommands.php:737:    if (!$item = $this->orangeDamApi->getContentItem($system_identifier)) {

Based on this, do we want to rename getContentItem() to queueContentItem() or keep it as is and create a new function called retrieveContentItem() :p that we call from within getContentItem()?

adamzimmermann’s picture

adamzimmermann commented
Assigned: adamzimmermann » apotek
Status: Active » Needs review

I went with this approach:

or keep it as is and create a new function called retrieveContentItem() :p that we call from within getContentItem()?

I named it slightly different though.

apotek’s picture

apotek commented
Status: Needs review » Reviewed & tested by the community

I have tested this change in my latest development work and getting good results.

  • adamzimmermann committed 95a5c81e on 1.x 
    Issue #3390295 by adamzimmermann, apotek: Allow Search API to be called...
adamzimmermann’s picture

adamzimmermann commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.