Closed (fixed)
Project:
Logging and alerts
Version:
2.0.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
27 Sep 2023 at 11:09 UTC
Updated:
20 Apr 2024 at 08:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #4
danrodI am getting this error when installing the errorlog module:
Fatal error: Declaration of Drupal\errorlog\Logger\ErrorLogMessageFormatter::log($level, $message, array $context = []) must be compatible with Drupal\Core\Logger\RfcLoggerTrait::log($level, Stringable|string $message, array $context = []): void in /var/www/html/web/modules/contrib/logging_alerts/errorlog/src/Logger/ErrorLogMessageFormatter.php on line 46Attached a patch to fix this.
Comment #5
viren18febs commentedComment #6
Madhu Kumar M E commentedThe above patch #4 applied cleanly is compatible with d10 , it can install the module without any issue, attached screenshot for the same
Comment #7
alina.basarabeanu commentedThe error reported by #4 is fixed with the issue 3382684.
The current pull request is fixing D10 compatibility only.
We need those changes in a new stable version to use the module on Drupal 10.
Comment #9
poker10 commentedI merged two other issues, so moving this to Needs Work.
We can finish the D10 compatibility issues from what is left here. If possible, we should keep D9 compatibility as well. Thanks!
I plan to publish the release once this issue is fixed.
Comment #10
vensiresComment #11
poker10 commentedSeems like that all that is left from the original changes in this MR is to change the
core_version_requirementand some other minor adjustments. So let's fix this. I have removed the newly added composer.json - we can still add it later, but I do not think we need it now (the file is not needed in certain circumstances: https://www.drupal.org/docs/develop/using-composer/add-a-composerjson-file).I have also changed
core_version_requirementfrom ^8 to ^8.8, as per: https://www.drupal.org/node/3070687 . I do not see any other D10 incompatibilities in the issue queue now, so going to commit this change.Comment #13
poker10 commentedComment #14
vensires