This patch updates the emaillog.info.yml and errorlog.info.yml files for Drupal 10 compatibility.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Alina Basarabeanu created an issue. See original summary.

chetan 11 made their first commit to this issue’s fork.

danrod’s picture

StatusFileSize
new589 bytes

I am getting this error when installing the errorlog module:

Fatal error: Declaration of Drupal\errorlog\Logger\ErrorLogMessageFormatter::log($level, $message, array $context = []) must be compatible with Drupal\Core\Logger\RfcLoggerTrait::log($level, Stringable|string $message, array $context = []): void in /var/www/html/web/modules/contrib/logging_alerts/errorlog/src/Logger/ErrorLogMessageFormatter.php on line 46

Attached a patch to fix this.

viren18febs’s picture

Status: Active » Needs review
Madhu Kumar M E’s picture

The above patch #4 applied cleanly is compatible with d10 , it can install the module without any issue, attached screenshot for the same

alina.basarabeanu’s picture

The error reported by #4 is fixed with the issue 3382684.
The current pull request is fixing D10 compatibility only.
We need those changes in a new stable version to use the module on Drupal 10.

zoiosilva made their first commit to this issue’s fork.

poker10’s picture

Status: Needs review » Needs work

I merged two other issues, so moving this to Needs Work.

We can finish the D10 compatibility issues from what is left here. If possible, we should keep D9 compatibility as well. Thanks!

I plan to publish the release once this issue is fixed.

vensires’s picture

Issue tags: +GreeceSpringSprint2024
poker10’s picture

Status: Needs work » Reviewed & tested by the community

Seems like that all that is left from the original changes in this MR is to change the core_version_requirement and some other minor adjustments. So let's fix this. I have removed the newly added composer.json - we can still add it later, but I do not think we need it now (the file is not needed in certain circumstances: https://www.drupal.org/docs/develop/using-composer/add-a-composerjson-file).

I have also changed core_version_requirement from ^8 to ^8.8, as per: https://www.drupal.org/node/3070687 . I do not see any other D10 incompatibilities in the issue queue now, so going to commit this change.

  • poker10 committed 0fe1f13f on 2.0.x authored by chetan 11
    Issue #3390107 by poker10, zoiosilva, Alina Basarabeanu, danrod: Drupal...
poker10’s picture

Status: Reviewed & tested by the community » Fixed
vensires’s picture

Issue tags: -GreeceSpringSprint2024

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.