Problem/Motivation

Inline entity form required version was bumped to 2.x in RS core 6.1.x. This version is not yet widely adopted, espcially by commerce which is still requiring the 1.x version. Because of this, it is not possible to start a new commerce project with RS 6.1.
On top of that, RS core do not make any use of this module, so this dependency is worthless

Proposed resolution

Remove drupal/inline_entity_form from rockership_core requirements.

CommentFileSizeAuthor
#3 remove_inline_entity_form_requirement-3389744.patch418 byteschetan 11

Issue fork rocketship_core-3389744

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nanak created an issue. See original summary.

nanak opened merge request !105

chetan 11’s picture

chetan 11 commented
StatusFileSize
new remove_inline_entity_form_requirement-3389744.patch418 bytes

Hi @nanak
I have remove the Inline Entity Form in composer.json file, attaching the patch also for reference.

nanak’s picture

nanak
Primary language French
Location Sarlat-la-Canéda
commented
Status: Active » Needs review

Thank you @chetan, that was already done in the merge request.

mallezie’s picture

mallezie
Primary language Dutch
Location Loenhout
commented
Status: Needs review » Reviewed & tested by the community

MR looks good to me, nothing more to change here.
We should mention this in the release notes however, for projects using IEF, so they can include it in their root composer.

nginex made their first commit to this issue’s fork.

nginex’s picture

nginex commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.