Problem/Motivation

Update the theme to use CKEditor 5
https://www.drupal.org/node/3259165

Steps to reproduce

1. Enable ckeditor5 and go to admin/config/content/formats and change all Text editors from CKEditor to CKEditor 5
2. Go to any field where CKEditor 5 is used (preferably the one that use Full HTML text format)

3a. Insert a Link
3b. You will see that link color is wrong and link is not underlined
3c. With this improvement applied, link has correct color and is underlined
3.d Furthermore, go to admin/appearance/settings/socialblue > Color scheme > Link color and change it - you should see the link color changed in CKEeditor as well

CKEditor4 (edit mode):
CKE4

CKEditor5 (edit mode, without this improvement):
CKE5

Front-end (content view, also expected result):
FE

4a. Insert a Block Quote
4b. You will see that Block Quote style is wrong, comparing to what is rendered when you view the content
4c. With this improvement applied, Block Quote style correct
4.d Furthermore, go to admin/appearance/settings/socialblue > Color scheme > Primary color and change it - you should see the Block Quote style changed in CKEeditor as well

CKEditor4 (edit mode):
CKE4

CKEditor5 (edit mode, without this improvement):
CKE5

Front-end (content view, also expected result):
FE

Proposed resolution

- Set ckeditor5-stylesheets: false to remove the warning without having to add any stylesheets.
- Apply socialblue color scheme defined in settings for link and blockquote html element in CKEditor 5.

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Issue fork socialblue-3389517

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

zanvidmar created an issue. See original summary.

zanvidmar’s picture

Title: Update the themes to use CKEditor 5 » Update the theme to use CKEditor 5
Related issues: +#3389513: Update the theme to use CKEditor 5
zanvidmar’s picture

Issue summary: View changes
StatusFileSize
new3.32 KB
new2.62 KB
new3.17 KB
zanvidmar’s picture

Issue summary: View changes
zanvidmar’s picture

Issue summary: View changes
StatusFileSize
new4.46 KB
new4.4 KB
new5.05 KB

zanvidmar’s picture

Status: Active » Needs review
zanvidmar’s picture

Issue summary: View changes
nkoporec’s picture

Status: Needs review » Reviewed & tested by the community

The changes looks good, I also tested it by using the latest Open Social and set the CKEditor 5 editor. The styles are applying correctly. Marking this as RTBC.

robertragas made their first commit to this issue’s fork.

robertragas’s picture

Landed in 2.5.3

robertragas’s picture

Status: Reviewed & tested by the community » Fixed
robertragas’s picture

  • robertragas committed b6040b2c on feature/3392337-throbber-icon-enroll-button authored by zanvidmar
    Issue #3389517: Update the theme to use CKEditor 5
    

  • robertragas committed b6040b2c on feature/3392440-migrate-socialblue-d10 authored by zanvidmar
    Issue #3389517: Update the theme to use CKEditor 5
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.