Problem/Motivation

Needed for bs_base issue #3389127: SVG logo is missing width and height.

CommentFileSizeAuthor
#6 3389133-svg-dimension-extraction-6.patch3.05 KBpivica
#6 interdiff-3389133-4-6.txt1.17 KBpivica
#4 3389133-svg-dimension-extraction-4.patch2.26 KBpivica
#4 interdiff-33891332-2-4.txt1.35 KBpivica
#2 3389133-svg-dimension-extraction-2.patch2.16 KBpivica

Comments

pivica created an issue. See original summary.

pivica’s picture

pivica commented
StatusFileSize
new 3389133-svg-dimension-extraction-2.patch2.16 KB

Here is a patch.

pivica’s picture

pivica commented
Status: Active » Needs review
pivica’s picture

pivica commented
StatusFileSize
new interdiff-33891332-2-4.txt1.35 KB
new 3389133-svg-dimension-extraction-4.patch2.26 KB

@Berdir suggested that we return FALSE if width or height is not defined, adjusted patch for that.

pivica’s picture

pivica commented
Status: Needs review » Needs work

Tested this a bit against various projects logo examples.
Works great but there is a problem, most of the time logo has width and height wihout unit, sometimes in px and sometimes in mm.
Checked SVG specification against it and units are allowed for SVG width and height. But for image element you can specify only values without units.

I guess the service needs to remove units from width and height values when they exist.

pivica’s picture

pivica commented
StatusFileSize
new interdiff-3389133-4-6.txt1.17 KB
new 3389133-svg-dimension-extraction-6.patch3.05 KB

Here is a new version which removes units.

pivica’s picture

pivica commented
Status: Needs work » Needs review

  • pivica committed cf12fa39 on 8.x-1.x 
    Issue #3389133 by pivica: Add service for extraction dimensions from SVG...
pivica’s picture

pivica commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.