Problem/Motivation

  • Fix the heat_template_version error

Issue fork cloud-3388999

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Xiaohua Guan created an issue. See original summary.

Xiaohua Guan opened merge request !2021

xiaohua guan’s picture

xiaohua guan commented
Status: Active » Needs review
xiaohua guan’s picture

xiaohua guan commented

yas made their first commit to this issue’s fork.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Fix the heat_template_version error » Fix the heat_template_version error in OpenStack stack template data
Issue summary: View changes
Status: Needs review » Needs work

@xiaohua-guan

Thank you for the fix. Can you add the BDD test case in OpenStack-ATDD-03-16-OperateStacks.feature for the test scenario w/ and w/o the single quotes? Thanks

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review

@yas

I've added test cases. Please take a look. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@xiaohua-guan

Thank you for adding the test scenario. I posted my minor comment. Thanks!

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review

@yas

Thanks for your comment. I've fixed it. Please take a look again. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue tags: +chatgpt
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for the fix. I ran the BDD testing and the tests have been passed successfully. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work

@xiaohua-guan

Can you please rebase the patch? Thanks

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for the update. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed 2dd88f44 on 6.x authored by Xiaohua Guan 
    Issue #3388999 by Xiaohua Guan, yas: Fix the heat_template_version error...

  • yas committed d6d6eb16 on 5.x authored by Xiaohua Guan 
    Issue #3388999 by Xiaohua Guan, yas: Fix the heat_template_version error...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Xiaohua Guan opened merge request !2038

xiaohua guan’s picture

xiaohua guan commented
Status: Fixed » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@xiaohua-guan

I ran the BDD tests but unfortunately, it didn't passed succssfully:

    Examples:
      | stack_name_operate                | heat_template_version  |
      | BDD_stack_0f52ca0_operate         | '2013-05-23' |
        Failed step: And I should see the success message "has been previewed"
        The page 'http://localhost/clouds/openstack/bdd_0f52ca0_regionone/stack' does not contain any success messages (Behat\Mink\Exception\ExpectationException)
        │
        │  Screenshot at: sites/screenshots/092823-185939_OpenStack-ATDD-03-16-OperateStacks_55F.png
        │
        └─ @AfterStep # Drupal\DrupalExtension\Context\DrupalContext::takeScreenshotOnFailure()
      | BDD_stack_0f52ca0_another_operate | 2013-05-23             |

Can you check it?

Thanks

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@xiaohua-guan

Thank you for the update. Can you please rebase the patch? Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@xiaohua-guan

I posted my comments. I think we can try to use |raw for the single quote (') escape. Thanks

xiaohua guan’s picture

xiaohua guan commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@xiaohua-guan

Thank you for the hotfix. I ran the BDD tests and the tests have been passed successfully. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.