A decade ago, #2194897: Rename Database\Query\Merge::key() to keys(), retain a BC alias for key() introduced Merge::keys(), and ::key() was meant to accept single key values.
However, that was not enforced and ::key() is still in use accepting array values.
Use deprecation tools that now are available and deprecate passing array $fields to ::key()
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !4832
Comments
Comment #3
mondrakeComment #4
smustgrave commentedGoing to mark as the deprecation seems good.
Only question is if we can reuse that CR or need a new one. That I can't answer.
Comment #5
mondrake#4 I think the existing one is enough. It says what is expected. If we were to write a new one I think we would just write the same things.
Comment #6
daffie commented+1 for RTBC
Comment #7
xjmCan we please attach the existing CR to this issue? Edit: Found it and did so, including adding a "Drupal 10.2 update" that it will now properly raise a deprecation.
The diff itself looks great.
Comment #8
xjmSaving credits. @smustgrave for the question about the CR and me for fixing it. :P
Comment #10
xjmCommitted to 11.x. Not backporting since it includes a new deprecation warning. Thanks!
I also toggled the status to "Draft" and back so that the CR would show up as a recent one instead of being buried in 2014 when Drupal 8.0.0 was still only an alpha.
Comment #12
mondrakeFiled #3390933: MergeTest::tesDeprecatedKeyArrayArgument() is mispelled, the test method name is misspelled.