Closed (fixed)
Project:
revolt
Version:
1.0.8
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
18 Sep 2023 at 11:13 UTC
Updated:
18 Oct 2023 at 08:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
rushikesh raval commentedPlease check it in project page it is Obsolete.
Comment #4
orkutmuratyilmaz@rushiraval, thanks for your warning. Then, I'm migrating this issue to revolt.
Comment #7
orkutmuratyilmazI've closed my first MR on the Virasat project and re-created it on revolt project. Also, I'm changing the status of this issue as "Needs review" respectively.
Comment #8
rushikesh raval commented@Orkut Murat Yılmaz I have tested your patch. Still same error is there. you need to make necessary change in vt-main.js
You can refer : https://www.drupal.org/node/3158256
Comment #9
rushikesh raval commentedComment #10
omkar-pd commentedThe patch will solve the issue. Replaced jquery/once with core/once.
Comment #11
omkar-pd commentedComment #12
rushikesh raval commentedI have test patch#10. It solve the problem. Moving it to RTBC
Comment #13
orkutmuratyilmaz@omkar-pd, thanks for imroving my patch. It really works better.
This MR deserves a merge.
Comment #16
yogesh.k commentedComment #17
orkutmuratyilmaz@yogesh.k, thanks for the merge, but it would be better to merge @omkar-pd's commit. My commit was buggy.
Comment #23
shubham_jain commentedHi, raised MR for the patch file in the comment #10 and updated the MR raised by the @Orkut Murat Yılmaz.
Please review MR !6.
Comment #24
orkutmuratyilmazI'd like to inform that MR !6 is working. Now I'm changing issue status as RTBC and version as 1.0.3.
Also, it could be a better practice to create a dev release, in order to collect commits and merge requests too.
Comment #26
yogesh.k commentedComment #27
yogesh.k commentedComment #28
pkghang commented