Problem/Motivation

We are seeing an error after upgrading to Drupal 10.1.3. Specifically this error:

TypeError: reset(): Argument #1 ($array) must be of type array, string given in reset() (line 247 of /code/web/modules/contrib/views_json_source/src/Plugin/views/filter/ViewsJsonFilter.php).

Steps to reproduce

We had the module installed and performed the upgrade to Drupal. Our view is now throwing this error.

Proposed resolution

I'm going to attempt a patch to fix.

CommentFileSizeAuthor
#3 3387673-3.patch704 bytesabelcain

Issue fork views_json_source-3387673

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

wheelercreek created an issue. See original summary.

wheelercreek opened merge request !4

abelcain’s picture

abelcain commented
StatusFileSize
new 3387673-3.patch704 bytes

For us is failing at version 10.1.2. We attach a patch based upon the solution at the MR#4

keshavv’s picture

keshavv commented
Status: Active » Needs review

The patch #3 looks good.

abelcain’s picture

abelcain commented

It would be good if the MR gets checked and merged, and a new release of module is done soon with this and other issues.

joao.ramos.costa’s picture

joao.ramos.costa commented

Hi @abelcain, the attached patch at #3 doesn't match with the MR-4:
https://git.drupalcode.org/project/views_json_source/-/merge_requests/4.... ,

just noticed by checking cweagans/composer-patches plugin failing not applying patch.

Cheers,

João.

astonvictor’s picture

astonvictor commented
Version: 8.x-1.4 » 2.0.x-dev

AstonVictor closed merge request !4

AstonVictor opened merge request !15

astonvictor’s picture

astonvictor commented

Hi there,

I was able to reproduce the error by enabling the Allow multiple selections option for the exposed filter.
Also, found that it doesn't work with exposed operators. So, fixed it as well.

astonvictor’s picture

astonvictor commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.