Problem/Motivation

  • Add the REST API to launch OpenStack Cloud Launch Template.

Issue fork cloud-3387448

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !2003

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

Please review it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add the REST API to launch OpenStack Cloud Launch Template » Add the REST API to launch OpenStack Cloud launch template in SPA (drupal/cloud_dashboard)
Issue summary: View changes
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the patch. Can you please take a look at the coding standards errors?

→ https://git.drupalcode.org/issue/cloud-3387448/-/jobs/89527

Thanks

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

Fix patch has been pushed. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the update. Can you please double-check the coding standards as follows?

FILE: .../html/web/modules/contrib/cloud/src/Controller/ApiController.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
 185 | WARNING | Unused private method deleteCloudLaunchTemplate()
 223 | WARNING | Unused private method launchCloudLaunchTemplate()
 228 | WARNING | \Drupal calls should be avoided in classes, use
     |         | dependency injection instead
----------------------------------------------------------------------
ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review
asai.noriaki’s picture

asai.noriaki commented
Status: Needs review » Reviewed & tested by the community

@yas @ryo-yamashita

Thank you for providing the patch.
I checked the patch and it worked. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add the REST API to launch OpenStack Cloud launch template in SPA (drupal/cloud_dashboard) » Add the REST API to launch OpenStack cloud launch template in SPA (drupal/cloud_dashboard)

@asai.noriaki

Thank you for your review.

@ryo-yamashita

I ran the BDD tests (NOT for SPA), and the tests have been passed successfully. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed 0f934b6f on 6.x authored by Ryo Yamashita 
    Issue #3387448 by Ryo Yamashita, yas, asai.noriaki: Add the REST API to...

  • yas committed 598a73a6 on 5.x authored by Ryo Yamashita 
    Issue #3387448 by Ryo Yamashita, yas, asai.noriaki: Add the REST API to...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.