Problem/Motivation

As identified in #3386809: Potential memory limit issue for pages with many words, the Definition filter plugin does not include caching metadata, making its result not cacheable efficiently.

Steps to reproduce

n.a.

Proposed resolution

Add cacheability metadata and tests demonstrating them.

Remaining tasks

All.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork g2-3387051

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fgm created an issue. See original summary.

fgm opened merge request !17

fgm’s picture

fgm
Primary language French
Location Paris, France
commented

Note: the Automatic filter has no notion of Drupal, including nodes: all it is aware of is the list of titles, found in the Aho-Corasick multi-matcher.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Active » Needs review

Hello @adevweb and team : could you check if this addresses your caching issues ?

  • fgm committed b5aa1dc8 on 8.x-1.x 
    Resolve #3387051 "Definition filter does not provide cache metadata"
fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Needs review » Fixed

Merged to current dev HEAD.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.