Problem/Motivation

I'd like to decouple the template of the language suggestion popup from the JS.
It will be more customizable, and overridable in theme.

Proposed resolution

- Define template
- Make new route for JS to get the rendered template
- Update JS

Issue fork language_suggestion-3386957

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

amourow created an issue. See original summary.

amourow’s picture

amourow
he/him/his
commented
Title: Move language suggestion popup out » Move language suggestion popup out of JS

amourow opened merge request !2

amourow’s picture

amourow
he/him/his
commented
Status: Active » Needs review
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Needs work
Issue tags: -templates

This needs a rebase.

amourow opened merge request !7

amourow closed merge request !2

amourow’s picture

amourow
he/him/his
commented
Title: Move language suggestion popup out of JS » Move language suggestion popup markup out of JS
Status: Needs work » Needs review
Related issues: +#3487118: Unable to call LanguageSuggestionController function due to wrong service name

I've rebased the code to the latest HEAD. However it will not work until the issue #3487118: Unable to call LanguageSuggestionController function due to wrong service name is fixed.

jeremy1606 made their first commit to this issue’s fork.

heddn’s picture

heddn
Primary language English
Location Illinois
commented

any chance we can address https://git.drupalcode.org/issue/language_suggestion-3386957/-/jobs/8090469

  • heddn committed a7d53d6a on 8.x-1.x authored by amourow 
    chore: #3386957 Move language suggestion popup markup out of JS

By:...
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Fixed

Thanks for the contributions.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.