Problem/Motivation

We use error suppression by silencing all array sorts testing \Drupal\Core\Config\Entity\ConfigEntityBase::sort.

The related comments are all similar to
// Suppress errors because of https://bugs.php.net/bug.php?id=50688.

This bug has been fixed in PHP 7.0 upwards, see the last comment on https://bugs.php.net/bug.php?id=50688:

[2017-12-06 18:14 UTC] nikic@php.net

Closing as this is fixed in PHP 7 and PHP 5.6 is out of active support.

Also https://3v4l.org/8NnXd shows the bug only occurring in the PHP range 5.2.11 - 5.2.17, 5.3.1 - 5.3.29, 5.4.0 - 5.4.45, 5.5.0 - 5.5.38, 5.6.0 - 5.6.40

Steps to reproduce

Proposed resolution

Remove error suppression.
Use Mocks in SearchPageRepositoryTest

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3386937

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
Title: Remove error suppression in \Drupal\Tests\Core\Config\Entity\ConfigEntityBaseUnitTest::testSort » Remove error suppressions and workarounds for https://bugs.php.net/bug.php?id=50688
Issue summary: View changes

Spokje opened merge request !4761

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Applied MR and searched for https://bugs.php.net/bug.php?id=50688. and all instances appear to be replaced.

catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 10.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 10.1.x, thanks!

  • catch committed 1d012fca on 10.1.x 
    Issue #3386937 by Spokje, smustgrave: Remove error suppressions and...

  • catch committed 3b490aae on 11.x 
    Issue #3386937 by Spokje, smustgrave: Remove error suppressions and...
catch’s picture

catch
he/him
Primary language English
commented

Spokje closed merge request !4761

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.