Problem/Motivation

This is a D7 backport of: #3050578: Remove unused function getSchemaUpdates()

Class ModuleUpdater defines a method getSchemaUpdates() which is not working and it is not used anywhere. We may want to remove it.

The method is deprecated in D10 as will be removed. In D7 the getSchemaUpdates() function does not work at all, because it contains a call to the _update_get_project_type() function, which is not defined. Therefore I think that it is pretty safe to remove it in D7 as well, to clean the code.

Proposed resolution

Remove the function. It cannot be used by contrib modules / custom code, because it cointains a call to an undefined function, so it is not working at all.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3386936-2.patch1.1 KBpoker10

Comments

poker10 created an issue. See original summary.

poker10’s picture

poker10 commented
Status: Active » Needs review
StatusFileSize
new 3386936-2.patch1.1 KB
poker10’s picture

poker10 commented
Title: [D7] Remove unused function getSchemaUpdates() » [D7] Remove unused/non-working function getSchemaUpdates()

Added a draft Change record for this. https://www.drupal.org/node/3386939

poker10’s picture

poker10 commented
Issue tags: +Pending Drupal 7 commit

Adding a tag for the review from another D7 maintainer before commit.

  • mcdruid committed dcf3c140 on 7.x 
    Issue #3386936 by poker10: Remove unused/non-working function...
mcdruid’s picture

mcdruid commented
Status: Needs review » Fixed
Issue tags: -Pending Drupal 7 commit

Less code is more good :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.