Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
I was reviewing the design and I observed that the styling of the pager is different from the design. In the design, there is a border defined on the items but in the current implementation, the styling is different. See the attached screenshot for reference.
Steps to reproduce
- Set up the Drupal site, and moved on Olivero theme.
- Add some content (Create articles and a basic page)
- See the pager styling (match with the design)
Proposed resolution
Need to style as per the design
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | Screenshot 2023-10-05 at 5.26.09 PM.png | 449.33 KB | hamid.ali |
| #3 | interdiff_2-3.txt | 1.44 KB | shweta__sharma |
| #3 | 3386916-3.patch | 1.83 KB | shweta__sharma |
| #2 | after-patch.png | 289.52 KB | shweta__sharma |
| #2 | 3386916-2.patch | 1.81 KB | shweta__sharma |
Issue fork drupal-3386916
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
compare
Comments
Comment #2
shweta__sharma commentedI have attached a patch for the same, also attached after patch screenshot for reference. please review
Comment #3
shweta__sharma commentedFixed the #2 errors.
Comment #4
smustgrave commentedI wouldn’t recommend digging through the figmas so much. There were design changes made before launch that aren’t included. So there’s a chance these can be closed won’t fix.
Comment #5
hamid.ali commentedI have tested the patch mentioned in Comment 3 and have identified several discrepancies when compared to the Figma design:
- The total number of visible items on Figma is 7
- The selected item colour, is not the same as per the Figma
- On hover, there is a blue border on the Figma which is missing
- When the first item is selected prev and the first buttons are hidden not disabled like in the Figma
- There are no ellipses on the Figma which is present in this case
- The colour of the numbers of the pagination item on select and hover are black in this case colour does not match as well
Comment #6
Vinayak.Ambig commentedsmustgrave with respect #4 can you please provide the reference where we may verify the deviations. According to that we can progress.
Comment #7
smustgrave commentedThey aren’t in the figmas anywhere but talking with the maintainer I know some changes were made. Which is why I wouldn’t recommended digging through the figmas looking for differences. 9/10 are probably working as designed.
So unless this provides an improvement, which haven’t tested, not sure this will make it. But could be wrong
Comment #8
johnv