Problem/Motivation

The module needs to be Drupal 10 compatible.

Steps to reproduce

Installing the module on Drupal 10 sites produces errors.

Proposed resolution

The code needs to be updated to ensure it is Drupal 10 compatible.

Remaining tasks

A patch has been created, it needs to be tested and reviewed by the community.

CommentFileSizeAuthor
#2 drupal-10-update-3386410-1.patch1.15 KBroaldnel

Comments

roaldnel created an issue. See original summary.

roaldnel’s picture

roaldnel commented
StatusFileSize
new drupal-10-update-3386410-1.patch1.15 KB

The proposed patch is attached.

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Issue tags: +finalist-sprint
batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Assigned: roaldnel » Unassigned
batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Issue tags: -finalist-sprint
batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Assigned: Unassigned » batigolix
batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Assigned: batigolix » Unassigned
bram.velthoven’s picture

bram.velthoven commented
Status: Needs review » Reviewed & tested by the community

Tested an setting to RTBC

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Issue tags: +finalist-sprint
arantxio’s picture

arantxio
Primary language Dutch
Location Dordrecht
commented
Status: Reviewed & tested by the community » Needs work

I would recommend removing the "core: 8.x" tag in the info.yml and also drop support for D8 because error logging change.

  • roaldnel committed a18afabc on 1.0.x 
    Issue #3386410 by roaldnel: Drupal 10 update
roaldnel’s picture

roaldnel commented
Version: 1.0.0 » 1.0.4
Status: Needs work » Fixed

Thank you Arantxio, I will remove Drupal 8 support in the release for this Issue: https://www.drupal.org/project/cm_commerce/issues/3393194.

The patch has been applied and the code has been merged so this task is now considered as fixed.

  • roaldnel committed a18afabc on main 
    Issue #3386410 by roaldnel: Drupal 10 update

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.