Problem/Motivation

  • Add an 'Edit' button to the OpenStack stack detailed view in Cloud Dashboard.

Issue fork cloud-3386367

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !1991

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

Please review it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add an 'Edit' button to the OpenStack stack detailed view in Cloud Dashboard » Add an 'Edit' button to the OpenStack stack detailed view in SPA (drupal/cloud_dashboard)
Issue summary: View changes
Status: Needs review » Needs work

@ryo-yamashita

Can you please rebase the patch due to the previous merge? Thanks

@asahi.noriaki @arutx-7557

What do you think?

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review
asai.noriaki’s picture

asai.noriaki commented
Status: Needs review » Reviewed & tested by the community

@yas @ryo-yamashita

I tested the provided patch and it worked. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work

@asai.noriaki

Thank you for your review.

@ryo-yamashita

Can you please rebase the patch due to the previous merge? Thanks!

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I rebased this patch. Thanks.

ryo yamashita’s picture

ryo yamashita commented

@yas

I pushed new commits and rebased this issue.
As noted, the conversion process has been refactored to improve readability.
Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +chatgpt

@asai.noriaki

Thank you for your review.

@ryo-yamashita

Thank you for the update. It looks more cleaner. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work

@ryo-yamashita

Can you please rebase the patch due to the previous merge? Thanks

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I rebased it again. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the update. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed 6608d51e on 6.x authored by Ryo Yamashita 
    Issue #3386367 by Ryo Yamashita, yas, asai.noriaki: Add an 'Edit' button...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

  • yas committed f0175d91 on 5.x authored by Ryo Yamashita 
    Issue #3386367 by Ryo Yamashita, yas, asai.noriaki: Add an 'Edit' button...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.