Problem/Motivation

  • Fix the form to edit OpenStack cloud launch template in SPA (drupal/cloud_dashboard).

Issue fork cloud-3386037

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !1984

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

Please review it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Category: Task » Feature request
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the fix. It looks good to me. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed 8f48e051 on 6.x authored by Ryo Yamashita 
    Issue #3386037 by Ryo Yamashita, yas: Fix the form to edit OpenStack...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work

@ryo-yamashita

Can you please create the MR for 5.x-dev? The git error is as follows. Thanks

remote: Enumerating objects: 86233, done.
remote: Counting objects: 100% (1768/1768), done.
remote: Compressing objects: 100% (720/720), done.
remote: Total 86233 (delta 1066), reused 1666 (delta 1000), pack-reused 84465
Receiving objects: 100% (86233/86233), 24.57 MiB | 21.11 MiB/s, done.
Resolving deltas: 100% (64612/64612), done.
Enumerating objects: 86233, done.
Counting objects: 100% (86233/86233), done.
Delta compression using up to 4 threads
Compressing objects: 100% (18978/18978), done.
Writing objects: 100% (86233/86233), done.
Total 86233 (delta 64612), reused 86233 (delta 64612), pack-reused 0
error: patch failed: modules/cloud_dashboard/css/index.css:1
error: modules/cloud_dashboard/css/index.css: patch does not apply
 .../templates/entity/openstack/launch_template.ts  |    1 +
 modules/cloud_dashboard/css/index.css              |    2 +-
 modules/cloud_dashboard/js/index.js                |    2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

error: patch failed: modules/cloud_dashboard/css/index.css:1
error: modules/cloud_dashboard/css/index.css: patch does not apply
On branch 5.x
Your branch is up to date with 'origin/5.x'.
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Category: Feature request » Bug report

Ryo Yamashita opened merge request !1988

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the patch for 5.x. I'll merge the patch to 5.x, and close this issue as Fixed.

  • yas committed eada00ff on 5.x authored by Ryo Yamashita 
    Issue #3386037 by Ryo Yamashita, yas: Fix the form to edit OpenStack...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.