Problem/Motivation

Drupal Core (10.2) now finally has built-in filename sanitation! See CR: https://www.drupal.org/node/2972665

I guess we should:

  1. Inform users of this module in the status report if they use Drupal >= 10.2.0 with a link to the change-record
  2. Inform potential users of this module on the module page and link to the Change record and issue
  3. Set the module deprecated in favour of the core functionality, at least once Drupal 9 is EOL

With the many core improvements happening, I think it's works to let users know and tell them they can uninstall the module, once they configured their installation accordingly.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#9 2023-10-26 15_08_10-Status report _ Drush Site-Install.png7.1 KBgrevil

Issue fork transliterate_filenames-3385940

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Anybody created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Issue summary: View changes
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Issue summary: View changes
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Title: Deprecate this module in favor of core functionality (>10.2) » Deprecate this module in favor of core functionality (>=10.2)
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

We could also think about automating the migration to the core settings releasing a 3.x version, which transfers the configuration from this module to the file.settings core config and afterwards uninstalls itself. What do you think?

Other deprecated modules which were merged into core or other contrib modules, did similar in the past.

grevil’s picture

grevil commented

We could also think about automating the migration to the core settings releasing a 3.x version, which transfers the configuration from this module to the file.settings

Let's do that in a follow-up issue! If needed!

Grevil opened merge request !3

grevil’s picture

grevil commented
Status: Active » Needs review

Set the module deprecated in favour of the core functionality, at least once Drupal 9 is EOL

I don't think we should do that, since Drupal 10.0.x and Drupal 10.1.x will then be still in use. These instances will also have the deprecation notice then if we use the

lifecycle: deprecated
lifecycle_link: xxx

approach in the info.yml. This can be quite confusing.

I guess the current implementation should be enough. Otherwise we could create a ^10.2.x only version and use the lifecycle properties, but I don't think that is necessary.

Please review!

grevil’s picture

grevil commented
StatusFileSize
new 2023-10-26 15_08_10-Status report _ Drush Site-Install.png7.1 KB
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

@Grevil: Thanks, just one comment for clarification on the module overview page.

Afterwards RTBC!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Could you ping the last active maintainer please to take a look at this issue? No maintainer activity here yet.

Also a note should be added to the module page and the module status should be changed.

grevil’s picture

grevil commented
Status: Needs work » Needs review

Done, please review again.

grevil’s picture

grevil commented

I send https://www.drupal.org/u/adubovskoy an email!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Perfect!

@Maintainers: Also a note should be added to the module page and the module status should be changed.

adubovskoy made their first commit to this issue’s fork.

  • adubovskoy committed a9857cbf on 2.0.x authored by Grevil 
    Issue #3385940 by Grevil, Anybody: Deprecate this module in favor of...
adubovskoy’s picture

adubovskoy commented
Status: Reviewed & tested by the community » Fixed

@Grevil, @Anybody thank you for your input! The module page is updated.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

joegl’s picture

joegl commented

If we're uninstalling this module and using the new "Sanitize filenames" settings at /admin/config/media/file-system, I assume we'd want to enable all the options and leave the Replacement Character as the dash? Thanks!

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
commented

yes, we want to enable all options. See https://git.drupalcode.org/project/transliterate_filenames/-/blob/8.x-1....