Problem/Motivation

The 'Access by Taxonomy' page gets displayed in the default theme, instead of the admin theme.
Though they can be one and the same, that isn't always the case.
I believe the page should be shown in the admin theme rather than the default theme. If this would be unwanted behavior, a developer can still configure the admin theme to be the default theme.

Steps to reproduce

  1. Install and enabled TAC Lite
  2. Go to admin/appearance, and make sure you have at least 2 themes installed
  3. Pick a theme, and set it as your 'default' theme
  4. Scroll to the bottom of the page, and choose an 'admin' theme. Do not choose 'default theme' or the actual name of the theme you chose in step 3
  5. Edit any User, and click on the 'Access by Taxonomy' tab
  6. The page should be shown in the 'default' theme, not the 'admin' theme

Proposed resolution

Add the _admin_route: TRUE option to the tac_lite.user_access Route.
More information: https://www.drupal.org/docs/drupal-apis/routing-system/structure-of-routes

The tac_lite.administration Route doesn't need this, because paths that start with '/admin' are by default to be considered admin routes.

CommentFileSizeAuthor
#5 3385159-access-by-taxonomy-admin-theme.patch380 bytesdrumanuel

Issue fork tac_lite-3385159

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

vodde83 created an issue. See original summary.

vodde83’s picture

vodde83 commented
Issue summary: View changes

vodde83 opened merge request !6

robindh’s picture

robindh commented
Status: Active » Reviewed & tested by the community

Ran into the same problem today. The attached merge request fixes the issue, moving to RTBC

drumanuel’s picture

drumanuel commented
StatusFileSize
new 3385159-access-by-taxonomy-admin-theme.patch380 bytes

Prefer a patch? I do

drumanuel’s picture

drumanuel commented

Doesn't seem to patch 1.7, working on it

drumanuel’s picture

drumanuel commented

Ok, my bad, patch is OK.

phily’s picture

phily
he/him
Primary language French
Location 🇪🇺🇫🇷 Paris, France
commented

Patch #5 works for using using Drupal 10.2.5

vladimiraus made their first commit to this issue’s fork.

  • vladimiraus committed aca3ae53 on 8.x-1.x authored by vodde83 
    Issue #3385159 by vodde83, drumanuel, robindh, phily: 'Access by...
vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Version: 8.x-1.7 » 8.x-1.x-dev
Status: Reviewed & tested by the community » Fixed

Thank you. Committed. 🎂

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.