Problem/Motivation

  • Fix the form to delete the OpenStack cloud launch template.

Issue fork cloud-3385104

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !1972

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes

@ryo-ymashita

Please check the coding standards:

FILE: .../html/web/modules/contrib/cloud/src/Controller/ApiController.php
----------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
----------------------------------------------------------------------
   1 | ERROR   | [ ] An error occurred during processing; checking
     |         |     has been aborted. The error message was:
     |         |     Undefined array key "scope_condition" in
     |         |     /var/www/html/vendor/squizlabs/php_codesniffer/src/Standards/Squiz/Sniffs/ControlStructures/SwitchDeclarationSniff.php
     |         |     on line 157
 149 | ERROR   | [x] There must be no space before the colon in a
     |         |     CASE statement
 165 | WARNING | [ ] Line exceeds 80 characters; contains 84
     |         |     characters
----------------------------------------------------------------------

I guess the first error is related to the second one. Probably fixing the second error will fix the first one.

Thanks

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Fix the form to delete OpenStack cloud launch template in Cloud Dashboard » Fix the form to delete OpenStack cloud launch template in SPA (drupal/cloud_dashboard)
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the update. Can you please rebase the patch due to the previous merge? Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Category: Task » Bug report
Issue tags: +chatgpt
ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I rebased this patch. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

Sorry, can you please rebase the patch again due to the previous merge? Thanks

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I rebased this patch again. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the update. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed 0ed1d520 on 6.x authored by Ryo Yamashita 
    Issue #3385104 by Ryo Yamashita, yas: Fix the form to delete OpenStack...

  • yas committed 3c0f77d7 on 5.x authored by Ryo Yamashita 
    Issue #3385104 by Ryo Yamashita, yas: Fix the form to delete OpenStack...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.