Problem/Motivation

In the DatabaseConnection_mysql we have a list of reserved keywords used by MySQL:

  /**
   * The list of MySQL reserved key words.
   *
   * @link https://dev.mysql.com/doc/refman/8.0/en/keywords.html
   */
  private $reservedKeyWords = array(
    ...
  );

In the meantime, two new keywords were added (see: https://dev.mysql.com/doc/refman/8.0/en/keywords.html):

  • INTERSECT (R); added in 8.0.31 (reserved)
  • LATERAL (R); added in 8.0.14 (reserved)

Some keywords were also removed, but for backwards compatibility I do not think we could remove them.

Proposed resolution

Add two new keywords.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3384545-2.patch587 bytespoker10

Comments

poker10 created an issue. See original summary.

poker10’s picture

poker10 commented
Status: Active » Needs review
StatusFileSize
new 3384545-2.patch587 bytes
poker10’s picture

poker10 commented
Issue tags: +Pending Drupal 7 commit

Adding a tag for the review from another D7 maintainer before commit.

mcdruid’s picture

mcdruid commented
Status: Needs review » Fixed
Issue tags: -Pending Drupal 7 commit

Agree that we should not remove keywords for BC.

Thanks!

  • mcdruid committed 5542bf25 on 7.x 
    Issue #3384545 by poker10: Update the list of reserved keywords in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.