Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
based on #332123-16: Remove t() from all schema descriptions
schema descriptions won't be translated in D7, it will be nice, if we do not need to translate them in D6 also..
Comments
Comment #1
Damien Tournoud CreditAttribution: Damien Tournoud commentedI recently discussed that with webchick. One idea could be to implement two modes: the "standard template" will not extract schema descriptions nor strings from test cases; a "developer template" will extract everything.
Comment #2
Gábor HojtsyAs long as we have t() in there, Drupal itself will complain about untranslated strings in your database, and people will blame potx for not extracting those. It would possibly be good to backport that patch to Drupal 6 and remove the t() from Drupal 6 core. Then only some contribs are left, which actually provide schema descriptions with t(). I bet that does not affect too modules :)
Comment #3
Gábor HojtsyI bet that does not affect too *many* modules that is :)
Comment #4
PasqualleI would say it affects most of the contrib modules which have schema description strings in their install files.. It is quite hard to find a schema description without t() call.
the backport sounds good..
Comment #5
hass CreditAttribution: hass commentedSubscribe - I'm not yet sure if I like this idea very much... especially after I've translated many modules and core. By one side it would be great to have less strings that needs to be translated - otherwise not. All modules I've translated have schema translations and this are many... or at least felt - many completed translations - I would guess 500 schema strings or much more. But having less strings sounds also alluring.
Maybe it's a better idea if we could extract the schema strings into an extra schema.pot and then let translators decide whether they like to translate the schema for schema API or not. l10n_server should show us the filename or that this is a schema translation...
Comment #6
Pasqualle@hass: please read Gábor's comments in #2 to understand that saving them into separate file does not really solve the problem
there is only one possible question: do we want t() on schema description or not?
as German is only 1 language from 42 (and more) supported languages for Drupal and 500 strings is only a small portion of all contrib module schema strings please support the issue about backporting #332123: Remove t() from all schema descriptions, and to have general coding style rules for contrib modules also (as there is no consensus between module developers yet). I think if we have your support on that issue we will not need anyone's else..
Comment #7
hass CreditAttribution: hass commented@Pasqualle: You should re-read what I've said. Gabor doesn't talk about moving schema strings in "schema.pot". 500 already translated strings was only guessing - it could be 1000 or more and German is not the only complete translations (NL and many others are complete, too). Aside 500 strings ARE VERY MANY strings and I'm worried that all this strings should now go to /dev/null. I'm not expect so much changes in this strings - so it's mostly a one time translation, but I do understand that other teams complain if they have 2500 new/changed strings in D6 core and this is really why the German translation also have taken a long time (8 months) to become complete - but only a very small part of them was missing schema strings as schema strings are typically easy to translate.
Comment #8
Pasqualleas it stand now, when you migrate to D7 your strings will go to /dev/null.. so can you convince others to revert that patch?
I just want general consensus and less translation work if it is possible..
Comment #9
Gábor Hojtsy@hass: Drupal 7 does not do any t() or st() on schema strings, so as Pasqualle says in #8 your translations are going to /dev/null sooner or later anyway. The point of backporting the removal of t() is to not waste *more* translator time on these strings, now that we've wasted enough. I did translate most schema strings for Drupal 6 core to Hungarian, and I am fine with the backport. I understand the reasons behind it, and I think it is superior to whatever amount of work I put into those strings. They will go extinct with Drupal 7 anyway. Why not stop others from wasting their times until then?
Comment #10
hass CreditAttribution: hass commentedI have no idea why this strings shouldn't be translated and D7 shouldn't drop them. Schema API make use of them.
Comment #11
Gábor Hojtsy@hass: maybe it would be good idea then to read the issue which was referenced two times already above: #332123: Remove t() from all schema descriptions
Comment #12
hass CreditAttribution: hass commentedThe only good reason I see is "we also don't translate code comments". But they all forget about the Schema module that can show the translated descriptions.
Comment #13
Gábor Hojtsy@hass: I am summarizing the details of that issue for you there. I think it would be better to not discuss an issue in another one, when you can equally question the original issue on the original issue itself. There the people who were pro or against the change could reply as well. Instead of your complaints tucked away in a contributed module's queue.
Comment #14
andypostMaybe extract schema strings into schema.pot file especially for Schema module?
But opposite this functionality should be included in schema not POTX.
So this issue should go to schema queue
Comment #15
hass CreditAttribution: hass commentedBut only POTX generates POT files for us... but as said - less strings are also fine as it's less work.
Comment #16
Damien Tournoud CreditAttribution: Damien Tournoud commentedMoving the scope now that schema descriptions are not translated anymore.
Comment #17
andypostBut #332123: Remove t() from all schema descriptions still not applyed for 6-dev brunch
Comment #18
Pasquallewhat is a test case string?
Comment #19
hass CreditAttribution: hass commentedHe may talk about simpletest tests... but not sure why the topic was changed to test case strings.
Comment #20
Gábor Hojtsy@Damien Tournoud: Schema descriptions are translated in 6, so please do not hijack this existing issue for another suggestion.
Comment #21
Gábor Hojtsy#332123: Remove t() from all schema descriptions is now in core. This is fixed. For further problems, open new issues please.