Problem/Motivation

Drupal 10 compatibility:

src/Event/MenuLinksEvent.php

Class Drupal\oidc_menu\Event\MenuLinksEvent extends deprecated class Symfony\Component\EventDispatcher\Event: since Symfony 4.3, use "Symfony\Contracts\EventDispatcher\Event" instead

oidc_menu.info.yml

Value of core_version_requirement: ^9 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687.

CommentFileSizeAuthor
#8 3383818-8.patch675 bytesjelle_s
#2 3383818.patch888 bytesmikell

Comments

michael.vdwalle@dropsolid.com created an issue. See original summary.

mikell’s picture

mikell commented
StatusFileSize
new 3383818.patch888 bytes
mikell’s picture

mikell commented
Status: Active » Needs review
mikell’s picture

mikell commented
Assigned: mikell » Unassigned

matthijs’s picture

matthijs
Primary language Dutch
commented
Status: Needs review » Fixed

Patch applied and committed, thanks!

jelle_s’s picture

jelle_s
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Fixed » Needs work

I'm getting

TypeError: Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher::dispatch(): Argument #1 ($event) must be of type object, string given, called in [...]/web/modules/contrib/oidc_menu/src/Plugin/Block/OpenidConnectMenuBlock.php on line 284 in Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch() (regel 89 van [...]/web/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php).

Patch incoming

jelle_s’s picture

jelle_s
Primary language Dutch
Location Antwerp, Belgium
commented
Version: 1.0.0-alpha4 » 1.0.x-dev
Status: Needs work » Needs review
StatusFileSize
new 3383818-8.patch675 bytes

Fixed the call to the dispatch method. I kept the usage of the event name in there for BC.

  • Matthijs committed 247732f9 on 1.x authored by Jelle_S 
    Issue #3383818 by Jelle_S: Fix order event dispatcher arguments
matthijs’s picture

matthijs
Primary language Dutch
commented
Status: Needs review » Fixed

Patch applied and committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.