Problem/Motivation

$ phpcs --standard=Drupalpractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml full_screen_mode

FILE: ...rs\abc\Downloads\full_screen_mode\src\Plugin\Block\FullScreenModeBlock.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 8 WARNINGS AFFECTING 8 LINES
--------------------------------------------------------------------------------
149 | WARNING | #description values usually have to run through t() for
| | translation
164 | WARNING | #description values usually have to run through t() for
| | translation
174 | WARNING | #description values usually have to run through t() for
| | translation
181 | WARNING | #description values usually have to run through t() for
| | translation
192 | WARNING | Unused variable $full_screen_mode_data_config.
193 | WARNING | Unused variable $current_full_screen_mode_image_ids.
194 | WARNING | Unused variable $current_header_image_ids.
195 | WARNING | Unused variable $items.
--------------------------------------------------------------------------------

Time: 1.64 secs; Memory: 8MB

CommentFileSizeAuthor
#8 full_screen_mode_phpcs_result.png20.06 KBsilvi.addweb
#8 full_screen_mode-applied_patch.png69.87 KBsilvi.addweb
#3 full_screen_mode_issue-3383645.patch18.67 KBchetan 11

Issue fork full_screen_mode-3383645

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Priya_Degwekar created an issue. See original summary.

chetan 11’s picture

chetan 11 commented
Assigned: Unassigned » chetan 11
chetan 11’s picture

chetan 11 commented
StatusFileSize
new full_screen_mode_issue-3383645.patch18.67 KB

Hi @Priya_Degwekar
I have fixed Drupal Coding Standard As Per phpcs --standard=Drupal.
Attached the patch for the same. Please review it.

priya_degwekar’s picture

priya_degwekar commented
Assigned: chetan 11 » Unassigned
Status: Active » Needs review
chetan 11’s picture

chetan 11 commented

silvi.addweb made their first commit to this issue’s fork.

silvi.addweb opened merge request !3

silvi.addweb’s picture

silvi.addweb commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new full_screen_mode-applied_patch.png69.87 KB
new full_screen_mode_phpcs_result.png20.06 KB

I've tested the #3 patch and raised MR for the same.

sujan shrestha’s picture

sujan shrestha commented
Version: 1.1.0 » 1.1.4
Status: Reviewed & tested by the community » Fixed

The issues related to the ‘Drupal coding standard as per phpcs --standard=Drupal’ issue has also been fixed. Thank you all for your valuable feedback.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.