Closed (fixed)
Project:
Cloud
Version:
6.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
28 Aug 2023 at 04:28 UTC
Updated:
13 Sep 2023 at 09:19 UTC
Jump to comment: Most recent
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
ryo yamashita commented@yas
Please review it. Thanks.
Comment #4
yas@ryo-yamashita
Thank you for fixing the issue. I posted my comment. Thanks
Comment #5
yasComment #6
yasComment #7
ryo yamashita commented@yas
To prevent hard-coding of logic, I cut out the possible processing for each type of entity as constant data. This allows for easy addition of functionality. Thanks.
Comment #8
yas@ryo-yamashita
Thank for the update with the refactoring. I like the refactoring. I think
menu_operations.tscan be separated tomenu_operations.tsandmenu_operations.jsonlike the existingmenu_template.tsandmenu_template.json.Or the JSON file can be the one used for both
menu_template.tsandmenu_operations.ts.What do you think?
Comment #9
ryo yamashita commented@yas
menu_template.json has a history of being automatically generated from an existing YAML file.
Therefore, it is possible to integrate the information in this file with menu_template.ts.
However, until the possibility of significant additions to menu_template.json arises, I don't see the need to refactor it yet. It is assumed that this issue can be closed as is. Thanks.
Note: If the contents of the data part of menu_operation.ts is separated into JSON, we will not be able to benefit from type inference when adding to the data part in the future. Therefore, there seems to be no particular advantage to creating menu_operation.json.
Comment #10
ryo yamashita commented@yas
To improve the readability of menu_operations.ts, the type definitions have been moved to the model directory. This makes menu_operations.ts easier to write. Thanks.
Comment #11
yas@ryo-yamashita
Thank you for the update. I like the refactoring. Please rebase the patch. Thanks
Comment #12
ryo yamashita commentedComment #13
yas@ryo-yamashita
Thank you for the update. I'll merge the patch to
5.xand6.x, and close this issue as Fixed.Comment #16
yas