Problem/Motivation

  • Fix action button labels in the detail view of OpenStack Floating IP.

Issue fork cloud-3383641

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Ryo Yamashita created an issue. See original summary.

ryo yamashita’s picture

Status: Needs work » Needs review

@yas

Please review it. Thanks.

yas’s picture

Title: Fix action button labels in the detail view of OpenStack Floating IP » Fix action button labels of the OpenStack floating IP detailed view
Issue summary: View changes
Status: Needs review » Needs work

@ryo-yamashita

Thank you for fixing the issue. I posted my comment. Thanks

yas’s picture

Issue tags: +chatgpt
yas’s picture

Category: Task » Bug report
ryo yamashita’s picture

Status: Needs work » Needs review

@yas

To prevent hard-coding of logic, I cut out the possible processing for each type of entity as constant data. This allows for easy addition of functionality. Thanks.

yas’s picture

Status: Needs review » Needs work

@ryo-yamashita

Thank for the update with the refactoring. I like the refactoring. I think menu_operations.ts can be separated to menu_operations.ts and menu_operations.json like the existing menu_template.ts and menu_template.json.

Or the JSON file can be the one used for both menu_template.ts and menu_operations.ts.

What do you think?

ryo yamashita’s picture

@yas

menu_template.json has a history of being automatically generated from an existing YAML file.

Therefore, it is possible to integrate the information in this file with menu_template.ts.

However, until the possibility of significant additions to menu_template.json arises, I don't see the need to refactor it yet. It is assumed that this issue can be closed as is. Thanks.

Note: If the contents of the data part of menu_operation.ts is separated into JSON, we will not be able to benefit from type inference when adding to the data part in the future. Therefore, there seems to be no particular advantage to creating menu_operation.json.

ryo yamashita’s picture

Status: Needs work » Needs review

@yas

To improve the readability of menu_operations.ts, the type definitions have been moved to the model directory. This makes menu_operations.ts easier to write. Thanks.

yas’s picture

Status: Needs review » Needs work

@ryo-yamashita

Thank you for the update. I like the refactoring. Please rebase the patch. Thanks

ryo yamashita’s picture

Status: Needs work » Needs review
yas’s picture

Title: Fix action button labels of the OpenStack floating IP detailed view » Refactor action button labels of the OpenStack floating IP detailed view in SPA (drupal/cloud_dashboard)
Category: Bug report » Task
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the update. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed c66b4e55 on 6.x authored by Ryo Yamashita
    Issue #3383641 by Ryo Yamashita, yas: Refactor action button labels of...

  • yas committed 0ca8e801 on 5.x authored by Ryo Yamashita
    Issue #3383641 by Ryo Yamashita, yas: Refactor action button labels of...
yas’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.