Problem/Motivation

The field Acknowledgment should be called Acknowledgments according to the RFC.
https://www.rfc-editor.org/rfc/rfc9116#name-acknowledgments

Also, there is a general typo in the module. It should not be acknowledgement but Acknowledgments

CommentFileSizeAuthor
#11 securitytxt_3383132_10_with_3375231.patch8.72 KBjoshahubbers
#11 interdiff_7_10.txt765 bytesjoshahubbers
#10 interdiff_5_10.txt765 bytesjoshahubbers
#10 securitytxt_3383132_10.patch8.59 KBjoshahubbers
#9 after_patch.png86.98 KBtanuja bohra
#8 after-patch.png294.9 KBshailja179
#8 before-patch.png432.54 KBshailja179
#7 securitytxt_3383132_5_with_3375231.patch8.54 KBralphvdhoudt
#5 securitytxt_3383132_5.patch8.41 KBjoshahubbers

Comments

JoshaHubbers created an issue. See original summary.

joshahubbers’s picture

joshahubbers commented
Issue summary: View changes
joshahubbers’s picture

joshahubbers commented
Issue summary: View changes
joshahubbers’s picture

joshahubbers commented
Issue summary: View changes
joshahubbers’s picture

joshahubbers commented
StatusFileSize
new securitytxt_3383132_5.patch8.41 KB

This patch corrects the typo and adds an update hook to migrate the value to the new config key and remove the old config key.

keshavv’s picture

keshavv commented
Status: Active » Needs review
ralphvdhoudt’s picture

ralphvdhoudt commented
StatusFileSize
new securitytxt_3383132_5_with_3375231.patch8.54 KB

Add a patch to be used in combination with issue #3375231

shailja179’s picture

shailja179 commented
StatusFileSize
new before-patch.png432.54 KB
new after-patch.png294.9 KB

I have applied the patch #5. Its working fine and changing the name properly.
RTBC +1.

tanuja bohra’s picture

tanuja bohra commented
StatusFileSize
new after_patch.png86.98 KB

@ralphvdhoudt, I verified the #7 patch and can you please check the "Acknowledgments" spelling is incorrect in description.

joshahubbers’s picture

joshahubbers commented
StatusFileSize
new securitytxt_3383132_10.patch8.59 KB
new interdiff_5_10.txt765 bytes

Fixed it for the original patch.

joshahubbers’s picture

joshahubbers commented
StatusFileSize
new interdiff_7_10.txt765 bytes
new securitytxt_3383132_10_with_3375231.patch8.72 KB

Fixed it for the patch that applies after #3375231: Language preferred and Canonical settings missing is applied.

tvoesenek’s picture

tvoesenek commented
Status: Needs review » Reviewed & tested by the community

Patch looks good and works as described

  • VladimirAus committed 2fbcd13e on 8.x-1.x 
    Issue #3383132 by JoshaHubbers, ralphvdhoudt, TVoesenek, VladimirAus:...
vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Reviewed & tested by the community » Fixed

Thank you! Committed! 🥂

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.