Problem/Motivation

The NameWidget has settings. One setting is 'Show the credentials inline'.

The credentials are shown on another line when 'Show the credentials inline' is checked and show inline when unchecked.

Steps to reproduce

Use the name widget, with inline widget layout. Toggle 'Show the credentials inline' to confirm the error.

Proposed resolution

Change name.module line 397 from 

if ($component == 'credentials' && !empty($element['#credentials_inline'])) {

to

if ($component == 'credentials' && empty($element['#credentials_inline'])) {

When the if statement is TRUE name-component-break is add as a css class.

name.inline.css

.name-component-break {
  clear: both;
}

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork name-3383062

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hermes_costell created an issue. See original summary.

keshavv made their first commit to this issue’s fork.

keshavv opened merge request !12

keshavv’s picture

keshavv commented
Status: Active » Needs review

I have created the MR as per the proposed solution.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Version: 8.x-1.0-rc5 » 8.x-1.x-dev
Status: Needs review » Needs work
Issue tags: +Needs title update

I'm not sure I understand what your are trying to communicate. Can you also update the title to better express the bug?

bluegeek9 made their first commit to this issue’s fork.

bluegeek9 changed the visibility of the branch 8.x-1.x to hidden.

bluegeek9’s picture

bluegeek9 commented
Title: Show the credentials inline is a backstabbing jerk » 'Show the credentials inline' causes opposite
Assigned: Unassigned » bluegeek9
Issue summary: View changes
Status: Needs work » Active
Issue tags: -Needs title update
bluegeek9’s picture

bluegeek9 commented
Assigned: bluegeek9 » Unassigned
Status: Active » Reviewed & tested by the community

liam morland made their first commit to this issue’s fork.

  • heddn committed 009399d7 on 8.x-1.x authored by keshavv 
    Issue #3383062 by bluegeek9, heddn: 'Show the credentials inline' causes...
heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the fixes here. Updating the issue title and description helped a lot.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.