Problem/Motivation

  • Hide enable_snat when creating or updating router if the user is not admin (Cloud Dashboard).

Issue fork cloud-3383054

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !1955

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

Please review it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Hide enable_snat when creating or updating router if the user is not admin (Cloud Dashboard) » Remove Enable SNAT (enable_snat) field when creating or updating OpenStack router in SPA if the user does not have an admin role (drupal/cloud_dasbhoard)
Issue summary: View changes
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the patch. I posted my comments. Thanks

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

Please review the new patch. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the update. It looks good. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed 506e9b1b on 6.x authored by Ryo Yamashita 
    Issue #3383054 by Ryo Yamashita, yas: Remove Enable SNAT (enable_snat)...

  • yas committed 4a44df87 on 5.x authored by Ryo Yamashita 
    Issue #3383054 by Ryo Yamashita, yas: Remove Enable SNAT (enable_snat)...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Ryo Yamashita opened merge request !1961

ryo yamashita’s picture

ryo yamashita commented
Status: Fixed » Needs review

@yas

A patch to eliminate Coding standard errors has been pushed. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for fixing the coding standards. I ran the phpcs and it looks good. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed 9605eda1 on 6.x authored by Ryo Yamashita 
    Issue #3383054 by Ryo Yamashita, yas: Hotfix - Remove Enable SNAT (...

  • yas committed 3c150066 on 5.x authored by Ryo Yamashita 
    Issue #3383054 by Ryo Yamashita, yas: Hotfix - Remove Enable SNAT (...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.