Problem/Motivation

  • Fix the access control on the Launch template before approval.
  • Fix it so that the access control is as follows.
    • Launch approved cloud launch template: Only approved Launch template can be launched.
    • Launch cloud launch template: All Launch templates can be launched, including unapproved ones.

Issue fork cloud-3382746

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nakamurarts created an issue. See original summary.

nakamurarts opened merge request !1949

phyllanthus’s picture

phyllanthus commented
Status: Active » Needs review

yas made their first commit to this issue’s fork.

sekinet’s picture

sekinet commented
Status: Needs review » Needs work

@nakamurarts

I posted my comments, please see them. Thanks.

phyllanthus’s picture

phyllanthus commented

@sekinet

Thank you for reviewing.
I corrected according to your suggestion. Please check.

phyllanthus’s picture

phyllanthus commented
Status: Needs work » Needs review
sekinet’s picture

sekinet commented
Status: Needs review » Needs work

@nakamurarts

I posted a minor comment. Could you please confirm?

phyllanthus’s picture

phyllanthus commented
Status: Needs work » Needs review

@sekinet

Thank you for your review and suggestions.

I have made the corrections according to your suggestions,
could you please check again?

sekinet’s picture

sekinet commented

@nakamurarts
Thank you for your update. It looks good.

@yas
What do you think?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

@sekinet

Thank you for your review.

@nakamurarts

Thank you for the update. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed 678403f7 on 6.x authored by nakamurarts 
    Issue #3382746 by nakamurarts, yas, sekinet: Fix the access control on...

  • yas committed c6f16771 on 5.x authored by nakamurarts 
    Issue #3382746 by nakamurarts, yas, sekinet: Fix the access control on...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Category: Task » Bug report

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.