Creation of dynamic property Drupal\views_aggregator\Plugin\views\style\Table::$commerce_field_values is deprecated

It's a PHP 8.1 thing, so you have to test against PHP 8.1. I triggered a test for you.

The parameter is commented wrong in your patch it should be: @var array

It would also be nice to have a test case that uses this code, so that the tests would show the error. The reasons this hasn't been seen before is because it's in that special case commerce code which isn't tested.

Also, since you're using the commerce integration, perhaps you can test #3376200: No aggregation total shown if first result is empty (commerce_price fields) ?

Thanks @TR, just tried, but sadly this is not fixed by #3376200: No aggregation total shown if first result is empty (commerce_price fields)

For details see https://www.php.net/manual/en/migration82.deprecated.php

Eventually it needs

adding the #[\AllowDynamicProperties] attribute to the class (which also applies to all child classes).

if this is required by design.

Personally I think when there's module-specific exceptions like this being made in the code, it's a giant red flag indicating that something is being done wrong.

Why should some commerce field be treated differently than any other Drupal field? How many modules do we have to make exceptions for?

Either Views Aggregator isn't doing the right thing, or the commerce module isn't constructing their field properly.

Yes, your MR would be the right way to fix things if we want to keep that variable around, but I personally would rather see this module fixed so it doesn't have to make exceptions like that. However I don't personally have the time or desire to set up a commerce site so I can investigate and figure out a proper solution.

@tr: Agreed! :)

Yeah, I'm not going to do any of those things I said in #10. I'm just going to add property, add a @todo, and open a new issue to examine the issue of potentially removing commerce-specific code.

Committed.