There are a number of code cleanup tasks that need to be addressed. For this initial cleanup let's fix the incorrect PHPDoc blocks and also remove the dead/commented out code.

In addition let's also address (most) of the phpcs notifications. We will leave the ones that require more significant changes and will handle them in separate issues, e.g. using container injection instead of directly referencing core services.

CommentFileSizeAuthor
#2 code-cleanup-3382696-2.patch29.68 KBtomtech

Comments

moxojo created an issue. See original summary.

tomtech’s picture

Assigned: Unassigned » tomtech
Status: Active » Needs review
StatusFileSize
new29.68 KB

  • TomTech authored 043cf798 on 2.x
    Issue #3382696 by TomTech, moxojo: Cleanup code to follow best practices
    
tomtech’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.