Problem/Motivation

Module is not working anymore in Drupal 10 when deleting a choice.
This is due to CR: https://www.drupal.org/node/3158256

Proposed resolution

Use once properly.

Remaining tasks

Create and review patch.

User interface changes

-

API changes

-

Data model changes

-

CommentFileSizeAuthor
#5 3381932_drupal-10-proper-once-dependency_5.patch1.01 KBtim-diels
#2 3381932_drupal-10-proper-once-dependency_2.patch875 bytestim-diels

Issue fork poll-3381932

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tim-diels created an issue. See original summary.

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Active » Needs review
StatusFileSize
new 3381932_drupal-10-proper-once-dependency_2.patch875 bytes

Thanks to tim@lammar.be who already created a patch but was lost as he posted that in a closed issue #3297878: Automated Drupal 10 compatibility fixes.

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Needs review » Needs work

Ugh patch was completely wrong as this was for a feature request not even merged yet. Apologies. New patch incoming.

tim-diels opened merge request !22

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new 3381932_drupal-10-proper-once-dependency_5.patch1.01 KB
keshavv’s picture

keshavv commented
Status: Needs review » Reviewed & tested by the community

Confirmed that there is an issue and that the given MR works well.
Moving to RTBC.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Any maintainer plans here?

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Issue tags: +DrupalCon Lille 2023

I'm having a look!

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.