Problem/Motivation

The Media pixabay api needs to have an api key set to a default value that is an empty string.

Steps to reproduce

  1. Install the module
  2. enable it
  3. try adding the entity browser widget without first setting up a media pixabal api key

You should see a "Oops, something went wrong. Check your browser's developer console for more details." error.

Proposed resolution

Allow setting up an empty string for api key via config install.

Remaining tasks

Write an update hook for those who already have the module installed and enabled.

Issue fork media_pixabay-3380692

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

DeaOm created an issue. See original summary.

agile-mark-l made their first commit to this issue’s fork.

agile-mark-l opened merge request !4

markman4897’s picture

markman4897 commented

I've added the mentioned update hook and also default configuration yml.

markman4897’s picture

markman4897 commented
Status: Active » Needs review
deaom’s picture

deaom commented
Version: 2.0.0 » 2.0.x-dev

The update hook was setting the default value to null, not empty string, it needs to be empty string, so updated that part of the code. In my POV can be merged, but because my change was last I'll leave it to needs review. The #3297621: Automated Drupal 10 compatibility fixes needs to be merged for test for D10 to pass, the config install is also added there.

slogar32’s picture

slogar32 commented
Assigned: Unassigned » slogar32

slogar32’s picture

slogar32 commented
Assigned: slogar32 » Unassigned
Status: Needs review » Reviewed & tested by the community
slogar32’s picture

slogar32 commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.