When the sidebar is collapsed there is no indication of which section you are in.
Add styles for the active/active trail states to the icon-only variation when the sidebar is collapsed.
See the designs of the example Active states: https://www.figma.com/file/fn52micITi1fCNtU0fWcPC/Prototype?type=design&...
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | Screenshot 2023-08-16 at 11.36.13 AM.png | 103.21 KB | claireristow |
| Captura de pantalla 2023-08-10 a les 19.17.44.png | 16.38 KB | ckrina |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #4
hooroomooworking on this
Comment #5
hooroomooComment #6
lauriiiThis breaks the logic for the second level menu links. Before this, if a second level menu item was active, the parent would collapse, making the active menu item visible. After this issue, the parent remains collapsed and therefore the active menu item is not visible.
Comment #8
ckrinaSorry I merged this without seen @lauriii's comment. @hooroomoo you will have to keep working from 1.x, sorry.
Comment #9
hooroomooComment #11
hooroomoo3380526-expand-menu MR is ready for review to fix the menu being expanded on refresh and also add that same behavior when the sidebar is collapsed too on hover.
Comment #12
hooroomooComment #13
claireristow commentedThat's looking great @hooroomoo! I'm noticing the sticky menu's shadow is not working anymore - that's added by the checkOverflow() function. After a quick code review I can't immediately see why it's not running... maybe we just need to add that function call to your new expandActiveMenu() function?
Comment #14
claireristow commentedComment #15
hooroomooComment #16
claireristow commentedThanks @hooroomoo, I'd say that's good to merge!
Comment #17
ckrinaThanks all!