Problem/Motivation

Transaction isolation read-committed: For this to work correctly, all tables must have a primary key. The following table(s) do not have a primary key: wisski_entity_field_properties, wisski_core_ontology_namespaces, wisski_calling_bundles, wisski_preview_images.

CommentFileSizeAuthor
#2 add_primary_keys.patch19.93 KBrnsrk

Comments

rnsrk created an issue. See original summary.

rnsrk’s picture

rnsrk commented
StatusFileSize
new add_primary_keys.patch19.93 KB

I've made a patch, but we have to check it carefully, because it alters the database table definitions and add primary keys. I also removed the deprecated schema_uninstall and _install hooks, this may have site effects to older drupal versions, we have to check this for drupal 8, 9 and 10 WissKI Version to avoid crashing the database or mess up the tables! And I added ['allowed_classes' => FALSE] to the unserialize()-Method, because serialization without this option is marked as unsecure - but I'm not sure if this is the right option - so we may substitute with json_encode anyway.

rnsrk credited gusriva.

rnsrk credited kaiamann.

rnsrk credited Knurg.

rnsrk credited philipp.eisenhuth.

rnsrk credited twiesing.

rnsrk’s picture

rnsrk commented
Assigned: rnsrk » knurg
Status: Active » Needs review

Forget the patch, we wrote update routines, which handles to remove duplicate rows and create primary keys with commit b9336181e6906d657cc2a32d0be716c1810c9479.

rnsrk’s picture

rnsrk commented
Status: Needs review » Fixed

We add primary keys to respective tables through the wisski_core/wisski_core.install patches 8010 to 8013.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.