Problem/Motivation

After install module when we try to save without any value is allow me to save .

Steps to reproduce

Install module.
go to admin/config/media/audio-embed-field
save the config without any value.
screenshot

Proposed resolution

field should be mandatory

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#11 audio_embed_field_issues_3380413_test_OK.png30.19 KBrushikesh raval
Screenshot from 2023-08-10 15-02-32.png57.89 KBshiv_sharma

Issue fork audio_embed_field-3380413

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Shiv_Sharma created an issue. See original summary.

kpoornima’s picture

kpoornima commented
Assigned: Unassigned » kpoornima

looking on it

sarwan_verma’s picture

sarwan_verma commented

I have successfully reproduced the issue on my local machine and fixed it locally.
Please refer to the attached patch.

keshavv made their first commit to this issue’s fork.

keshavv opened merge request !5

keshavv’s picture

keshavv commented
Status: Active » Needs work

Created MR please review.

keshavv’s picture

keshavv commented
Status: Needs work » Needs review
sarwan_verma’s picture

sarwan_verma commented
Status: Needs review » Active
sarwan_verma’s picture

sarwan_verma commented
StatusFileSize
new Screenshot.png108.75 KB
new audio_embed_field_validation-3380413-1.patch1.16 KB
sarwan_verma’s picture

sarwan_verma commented
Status: Active » Needs review
rushikesh raval’s picture

rushikesh raval commented
Assigned: kpoornima » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new audio_embed_field_issues_3380413_test_OK.png30.19 KB

I have tested MR !5 for #5. It now said fields is compulsory. I have attached Testing Screenshot.

mably’s picture

mably commented
Status: Reviewed & tested by the community » Closed (won't fix)

Looks like it should be mandatory only if you intend to embed Soundcloud audios.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.