Problem/Motivation

While checking with PHPCS, able to see some errors. Needs to fix them

Steps to reproduce

Run PHPCS can show us errors/suggestions

Proposed resolution

Check the errors/suggestions and need fix for them
FILE: /var/www/html/web/modules/contrib/find_external_links-3379871/src/Form/ConfigurationForm.php
--------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------
158 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
238 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
242 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

bhanutejaswi created an issue. See original summary.

kpoornima’s picture

Assigned: bhanutejaswi » kpoornima

Looking on it

rajan kumar’s picture

Version: 8.x-2.0 » 3.0.0
bhanutejaswi’s picture

Issue summary: View changes

kpoornima’s picture

Assigned: kpoornima » Unassigned
Status: Needs work » Needs review

Please review

nishant’s picture

Review the above MR and it's working fine for me.

shiv_sharma’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new46.04 KB

MR looks good no new warning on src/Form/ConfigurationForm.php file.
after patch screenshot

rajan kumar’s picture

Status: Reviewed & tested by the community » Fixed

I have review & merge above MR in latest version.

rajan kumar’s picture

Status: Fixed » Closed (fixed)