Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
6 Aug 2023 at 09:17 UTC
Updated:
3 Nov 2023 at 17:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
poker10 commentedUpdated the wording in the IS and added a patch for
INSTALL.txt+ other files (base on #3319435: Update system requirements (including INSTALL.txt) for D7).As in the other issue we committed earlier, I suppose we should add a change record or at least release note mention, because all sites on PHP lower than PHP 5.6 will be unable to run
update.phpafter this is released (see ).Comment #3
poker10 commentedWe have discussed this with @mcdruid on Slack and think that it will be better not to block DrupalCI / update.php on lower PHP versions right now.
Uploading a modified patch, which will block only installing a new Drupal site on PHP < 5.6 (which is something, that nobody should do these day anyway) and which is updating text requirements.
Comment #4
mcdruid commentedI've updated the docs pages listed (1,2,3) in the IS.
Discussed with @poker10 that we might not remove D7's ability to run tests in earlier PHP versions (e.g. by updating the DRUPAL_MINIMUM_PHP constant).
However, that doesn't mean older versions are still supported - it just might be useful to be able to check whether proposed changes will break in versions that are no longer actively supported / recommended.
Comment #5
poker10 commentedThe PHP 5.3 testing now has one failure - https://www.drupal.org/pift-ci-job/2743110:
testInternalBrowser
It seems like this part of the code is checking that access to the
install.phpis disabled while running tests (see: #225880: non-writablilty of settings.php when created by webserver). The code is supposed to run and return 403 a bit further:We should either add a similar check to the
install.php(probably not worth), or keep it as it is, as the test is passing in other PHP versions, so it is still being tested if everything is OK. This failure will also highlight that the PHP 5.3 is unsupported, as there will be at least this one mentioned failure present.Comment #6
poker10 commentedOr we could also add a 403 header to the
install.php, just before theexitcall.But personally, I think that this one failure in unsupported PHP version is not a problem.
Comment #7
poker10 commentedI have drafted a change record: https://www.drupal.org/node/3383555
I think this is ready to be committed (patch #3).
Comment #8
mcdruid commentedYup this looks good to me +1
Comment #10
poker10 commentedCommitted, thanks!
I have also removed the
PHP 5.3 & MySQL 5.5from core auto-testing (but it can still be triggered manually in the future, if needed, until the DrupalCI is turned off).Seems like all points are addressed, so closing this.